Skip to content

Add proper Architectures entries in "generate-stackbrew-library.sh" #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

@tianon
Copy link
Member Author

tianon commented Jun 16, 2017

$ diff -u <(bashbrew cat rabbitmq) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63	2017-06-16 16:34:25.598094189 -0700
+++ /dev/fd/62	2017-06-16 16:34:25.598094189 -0700
@@ -2,10 +2,12 @@
 GitRepo: https://github.com/docker-library/rabbitmq.git
 
 Tags: 3.6.10, 3.6, 3, latest
+Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
 GitCommit: a6cb36022a5c1a17df78cfafe45a73d941ad4eb8
 Directory: 3.6/debian
 
 Tags: 3.6.10-management, 3.6-management, 3-management, management
+Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
 GitCommit: 79277042564875d55e4b05a60c65b6eb46651a94
 Directory: 3.6/debian/management
 

@tianon
Copy link
Member Author

tianon commented Jun 16, 2017

(Will be even better once Alpine goes multiarch, especially since Alpine 3.6 supports more arches than Alpine 3.5. 😄)

@tianon
Copy link
Member Author

tianon commented Jun 16, 2017

(cancelled Travis so we don't waste cycles doing nothing)

@tianon tianon merged commit 0797005 into docker-library:master Jun 19, 2017
@tianon tianon deleted the multiarch branch June 19, 2017 16:33
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jun 19, 2017
- `haproxy`: 1.6.13
- `irssi`: Alpine 3.6 (docker-library/irssi#16), multiarch (docker-library/irssi#15)
- `python`: 3.6.2rc1
- `rabbitmq`: Debian Stretch and Alpine 3.6 (docker-library/rabbitmq#166), multiarch (docker-library/rabbitmq#167)
@tianon
Copy link
Member Author

tianon commented Jun 20, 2017

Whoops: https://packages.debian.org/stretch/erlang-base-hipe#pdownload 😇

(erlang-base-hipe has a limited set of arches, so we need to make that installation conditional on whether the package is available for our current arch, especially since the usage of it is already optional 👍)

@tianon
Copy link
Member Author

tianon commented Jun 20, 2017

Ah, and our second problem: https://www.rabbitmq.com/debian/dists/testing/Release (Architectures: AVR32 alpha amd64 arm armel armhf hppa hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 m32 m68k mips mipsel netbsd-alpha netbsd-i386 powerpc s390 s390x sh sparc)

The package itself is arch:all, but ppc64el isn't included in this list, so our ppc64le build server won't find the package. 😅

@michaelklishin how feasible do you think it'd be to have whoever maintains that repository add ppc64el too? (it doesn't require a .deb rebuild, simply extra metadata to tell ppc64el where to find the existing arch:all .deb file 😇) If there's a "proper" place to file that, I'm happy to file the issue/request myself too. 👍

@tianon
Copy link
Member Author

tianon commented Jun 20, 2017

I'm really good at looking closely -- appears to be missing arm64 too (but armhf, i386, and s390x built successfully!)

@tianon
Copy link
Member Author

tianon commented Sep 6, 2017

Found the right place to file a PR for that Architectures list! 😇 (rabbitmq/rabbitmq-server-release#47)

@yosifkit yosifkit mentioned this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants