Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

packaging/debs/apt-repository/distributions: Add more valid Architectures #47

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Sep 6, 2017

See the first column of https://sources.debian.net/src/dpkg/stretch/data/cputable/ for where these values were sourced from.

Realistically, I'm mostly interested in ppc64el being added here, but figured while I was at it, I might as well look for an upstream dpkg source-of-truth table to get more valid values.

I'm also happy to update this to be less aggressive if this fuller list is undesirable. 😇

(or to send this request/PR elsewhere if there's somewhere more appropriate for it to be filed ❤️)

@@ -2,6 +2,6 @@ Origin: RabbitMQ
Label: RabbitMQ Repository for Debian / Ubuntu etc
Suite: testing
Codename: kitten
Architectures: AVR32 alpha amd64 arm armel armhf arm64 hppa hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 m32 m68k mips mipsel netbsd-alpha netbsd-i386 powerpc s390 s390x sh sparc source
Architectures: AVR32 alpha amd64 arm arm64 armeb armel armhf avr32 hppa hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 m32 m32r m68k mips mips64 mips64el mips64r6 mips64r6el mipsel mipsr6 mipsr6el netbsd-alpha netbsd-i386 nios2 or1k powerpc powerpcel ppc64 ppc64el s390 s390x sh sh3 sh3eb sh4 sh4eb sparc sparc64 tilegx source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know the difference between AVR32 and avr32? It feels like the uppercase one (the first entry in the list) is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think you're right -- want me to remove the uppercase version, since dpkg should never use it according to the dpkg source?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon please do.

@dumbbell dumbbell self-assigned this Sep 7, 2017
@dumbbell dumbbell merged commit 57c785d into rabbitmq:master Sep 8, 2017
@tianon tianon deleted the dpkg-arches branch September 8, 2017 14:35
@michaelklishin
Copy link
Contributor

@dumbbell @tianon should this be backported to stable?

@dumbbell
Copy link
Contributor

dumbbell commented Sep 8, 2017

I cherry-picked the two commits to stable already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants