Support for azure openai via the standard openai provider #117
+175
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes docker#112 Signed-off-by: Christopher Petito <[email protected]>
krissetto
commented
Sep 5, 2025
| @@ -102,6 +140,14 @@ func (c *Client) newGatewayClient(ctx context.Context) *openai.Client { | |||
| return openai.NewClientWithConfig(cfg) | |||
| } | |||
|
|
|||
| // isAzureBaseURL returns true if the base URL points to Azure OpenAI | |||
| func isAzureBaseURL(u string) bool { | |||
There was a problem hiding this comment.
Alternatively to this, we could maybe use another provider_opts key such as azure: true
models:
azure:
provider: openai
...
provider_opts:
azure: true
...
There was a problem hiding this comment.
I could imagine that at some point Azure OpenAI would support custom domains. Then it would be useful to have the option key. Or maybe react on the azure_api_version? If that is set, it has to be Azure OpenAI and vice versa
There was a problem hiding this comment.
Testing a bit more, I now indeed got an endpoint that ends with .cognitiveservices.azure.com. That doesn't work with the currently proposed implementatoin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for supporting AzureOpenAI using the standard OpenAI provider
closes #112