-
Notifications
You must be signed in to change notification settings - Fork 54
Support for azure openai via the standard openai provider #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krissetto
wants to merge
1
commit into
docker:main
Choose a base branch
from
krissetto:azure-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
package openai | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
latest "github.com/docker/cagent/pkg/config/v2" | ||
"github.com/docker/cagent/pkg/environment" | ||
) | ||
|
||
type mapEnv struct{ m map[string]string } | ||
|
||
func (e mapEnv) Get(ctx context.Context, name string) string { return e.m[name] } | ||
|
||
func TestIsAzureBaseURL(t *testing.T) { | ||
cases := []struct { | ||
in string | ||
want bool | ||
}{ | ||
{"", false}, | ||
{"https://api.openai.com/v1", false}, | ||
{"https://myres.openai.azure.com/", true}, | ||
{"HTTPs://MYRES.OpenAI.AZURE.COM/openai/v1/", true}, | ||
{"http://localhost:8080/v1", false}, | ||
} | ||
for _, tc := range cases { | ||
if got := isAzureBaseURL(tc.in); got != tc.want { | ||
t.Fatalf("isAzureBaseURL(%q)=%v, want %v", tc.in, got, tc.want) | ||
} | ||
} | ||
} | ||
|
||
func TestNewClient_AzureRequiresAPIVersion(t *testing.T) { | ||
ctx := context.Background() | ||
cfg := &latest.ModelConfig{ | ||
Provider: "openai", | ||
Model: "my-deployment", // deployment name for Azure | ||
BaseURL: "https://myres.openai.azure.com/", | ||
} | ||
env := mapEnv{m: map[string]string{ | ||
"AZURE_OPENAI_API_KEY": "azure-key", | ||
// OPENAI_API_KEY intentionally missing to exercise fallback | ||
}} | ||
c, err := NewClient(ctx, cfg, environment.Provider(env)) | ||
if err == nil || c != nil { | ||
t.Fatalf("expected error due to missing azure_api_version, got client=%v, err=%v", c, err) | ||
} | ||
} | ||
|
||
func TestNewClient_AzureWithAPIVersionSucceeds(t *testing.T) { | ||
ctx := context.Background() | ||
cfg := &latest.ModelConfig{ | ||
Provider: "openai", | ||
Model: "my-deployment", | ||
BaseURL: "https://myres.openai.azure.com/", | ||
ProviderOpts: map[string]any{ | ||
"azure_api_version": "2024-10-21", | ||
}, | ||
} | ||
env := mapEnv{m: map[string]string{ | ||
"AZURE_OPENAI_API_KEY": "azure-key", | ||
}} | ||
c, err := NewClient(ctx, cfg, environment.Provider(env)) | ||
if err != nil || c == nil { | ||
t.Fatalf("expected client without error, got client=%v, err=%v", c, err) | ||
} | ||
} | ||
|
||
func TestNewClient_AzureMissingKeysReturnsError(t *testing.T) { | ||
ctx := context.Background() | ||
cfg := &latest.ModelConfig{ | ||
Provider: "openai", | ||
Model: "my-deployment", | ||
BaseURL: "https://myres.openai.azure.com/", | ||
} | ||
env := mapEnv{m: map[string]string{}} | ||
c, err := NewClient(ctx, cfg, environment.Provider(env)) | ||
if err == nil || c != nil { | ||
t.Fatalf("expected error due to missing keys, got client=%v, err=%v", c, err) | ||
} | ||
} | ||
|
||
func TestNewClient_NonAzureUsesOpenAIKey(t *testing.T) { | ||
ctx := context.Background() | ||
cfg := &latest.ModelConfig{ | ||
Provider: "openai", | ||
Model: "gpt-4o", | ||
// BaseURL left empty to use default OpenAI | ||
} | ||
env := mapEnv{m: map[string]string{ | ||
"OPENAI_API_KEY": "openai-key", | ||
}} | ||
c, err := NewClient(ctx, cfg, environment.Provider(env)) | ||
if err != nil || c == nil { | ||
t.Fatalf("expected client without error, got client=%v, err=%v", c, err) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively to this, we could maybe use another
provider_opts
key such asazure: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could imagine that at some point Azure OpenAI would support custom domains. Then it would be useful to have the option key. Or maybe react on the azure_api_version? If that is set, it has to be Azure OpenAI and vice versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing a bit more, I now indeed got an endpoint that ends with
.cognitiveservices.azure.com
. That doesn't work with the currently proposed implementatoin