Conversation
thaJeztah
added
status/2-code-review
area/stack
kind/refactor
thaJeztah
changed the title
thaJeztah
marked this pull request as ready for review
April 12, 2023 20:59
thaJeztah
force-pushed
the
compose_stronger_typed
branch
from
July 25, 2023 04:59
8f6ff0f to
eede5eb
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
compose_stronger_typed
branch
from
July 25, 2023 05:41
eede5eb to
1f7311c
Compare
thaJeztah
commented
Jul 25, 2023
Comment on lines
+7
to
+8
|
|
||
| "github.com/docker/docker/api/types/mount" |
Member
Author
There was a problem hiding this comment.
I think the reason these types were not imported was to make the compose-types not directly depend on docker API types, and to keep it "agnostic".
Now that the compose-spec exists, I don't think that should still be a concern, as the compose implementation in this repository is only for docker stack; users that want a more agnostic implementation are better off using the compose-spec as a library than the types from this repo.
thaJeztah
force-pushed
the
compose_stronger_typed
branch
from
July 25, 2023 06:49
1f7311c to
7d7b4a1
Compare
Using a strong type for this field, to make it clearer what's supported, and to allow assigning values without having to convert them to a string. Also renamed a variable that collided with an import. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> WIP: change type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…cy field Using a strong type for this field, to make it clearer what's supported, and to allow assigning values without having to cast them. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
compose_stronger_typed
branch
from
September 3, 2026 16:40
7d7b4a1 to
ebdd5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/compose/types: ServiceVolumeConfig: use strong type for Type field
Using a strong type for this field, to make it clearer what's supported,
and to allow assigning values without having to convert them to a string.
Also renamed a variable that collided with an import.
cli/compose/types: ServiceVolumeConfig: use strong type for Consistency field
Using a strong type for this field, to make it clearer what's supported,
and to allow assigning values without having to cast them.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)