Refactoring of redundant condition checks

[suwakei]

Problem:

Redundant condition check:
In the init() function, the version string is parsed using the github.com/hashicorp/go-version library.
The NewVersion function of this library always returns a version object with three segments: major, minor, and patch, if parsed successfully (e.g., “v1.2” is interpreted as “v1.2.0”).
Thus, the check if len(segments) > 2 after if err == nil is always true and redundant.

How to construct the version string:
Rather than manually reconstructing the version string using fmt.Sprintf, it is clearer in intent and more idiomatic to use the Core() method provided by the go-version library.

Lack of test
No tests were included to verify the behavior of pkg/api/labels.go, especially the initialization logic of the global variable ComposeVersion by the init() function.

Fix:

To improve these points, the init() function has been modified as follows Remove the redundant if statement and use v.Core().String() to set the ComposeVersion.

func init() {
	v, err := version.NewVersion(internal.Version)
	if err == nil {
		--- segments := v.Segments()
		--- if len(segments) > 2 {
			--- ComposeVersion = fmt.Sprintf("%d.%d.%d", segments[0], segments[1], segments[2])
		--- }
		+++ ComposeVersion = v.Core().String()
	}
}

Create a new test file called pkg/api/labels_test.go and add a test case that validates the initialization logic of ComposeVersion.

• ComposeVersion should be the core version such as 2.1.0 even if internal.Version contains pre-release information such as v2.1.0-beta.

• ComposeVersion should remain an empty string if internal.Version is a non-parsable string such as “devel”.

Added tests to validate these cases.
This improves maintainability and correctness of version handling.

[suwakei]

Thanks for the review! Since I don’t have write access, auto-merge is disabled.
Could you please merge it manually if everything looks good?