Can not Export CREATOR Field for IParcelable instance #1149

fullmetaltac · 2018-01-02T15:33:53Z

Sample link

https://github.com/xamarin/monodroid-samples/blob/f944f42001fa134915069fa7bbb9cb493bfd446d/ExportAttribute/ExportAttributeTest/MainActivity.cs#L55
https://github.com/xamarin/monodroid-samples/blob/f944f42001fa134915069fa7bbb9cb493bfd446d/android5.0/Topeka/Topeka/Models/Player.cs#L18

Verified on Monodroid v8.2.0.1

Issue description

Can not ExportField CREATOR for IParcelable instance

Steps to reproduce the issue

Open Topeka sample.
Input login info.
Tap Login button.

What's the expected result?

User successfully login.

What's the actual result?

Application crashes.

Steps to reproduce the issue

Open ExportAttributeTest sample.
Tap button.

What's the expected result?

Parcelable object handled properly.

What's the actual result?

Application crashes.

Additional details / screenshot (Optional)

InitializeCreator method is not reachable via debugger.
MSBuildOutput.log
logCat.txt

jonpryor · 2018-01-02T20:03:28Z

This does not crash on d15-5/Xamarin.Android 8.1.

@fullmetaltac: Does this happen in the Debug configuration or when linking is disabled?

@radekdoulik: I suspect that this is a linker bug, and that Player.InitializeCreator() is being linked away, which would explain why it can't be found.

Could this be related to PR #1059?

fullmetaltac · 2018-01-03T10:02:46Z

@jonpryor I tried with Visual Studio Tools for Xamarin v4.9.0.669 and v4.8.0.753 both with Release and Debug configurations. I tested on real device Xiaomi Redmi 3S (v6.0.1) and with Nexus One (API:27) emulator. Result the same in each case.

Here is crash info from device. The same error I was getting spontaneously and was not able to write concrete steps to reproduce. This error getting periodically and I hope has the same root cause.

fullmetaltac · 2018-01-03T10:03:57Z

@jonpryor Should I close this duplicate?
dotnet/android-samples#254

radekdoulik · 2018-01-08T13:11:40Z

Looks like it is not Linker related. Happens in Debug configuration as well.

I will try to find out why it fails.

radekdoulik · 2018-01-08T13:47:35Z

@jonathanpeppers Looks like it might be related to dotnet/java-interop@429dc2a

Do you know what might be wrong here? Looks like we might be looking for wrong signature?

jonpryor · 2018-01-08T14:39:16Z

@radekdoulik: @jonathanpeppers is OOF until ~march, so don't expect much from him. :-)

I also doubt that it's dotnet/java-interop@429dc2a, as the bug is reported against d15-6, and the referenced Java.Interop commit should only be in d15-7/master, not d15-6. (At least it better not be in d15-6; I wanted it to get more testing!)

I don't see that commit in https://github.com/xamarin/Java.Interop/commits/d15-6.

@radekdoulik: Do you have any additional information to bring to the table?

radekdoulik · 2018-01-08T16:22:35Z

@jonpryor Indeed. Another candidate might be dotnet/java-interop@cb161d2

Trying to find out more about it.

radekdoulik · 2018-01-08T20:47:03Z

The above mentioned commit indeed caused the regression.

The signature for the InitializeCreator signature is now ()Ljava/lang/Object; while it was ()Lmd59b7a7576784821ea63294fbca8600da1/Creator_1; before.

jonpryor · 2018-01-08T21:44:11Z

@radekdoulik: I think I have a theory. Consider JavaNativeTypeManager.ToJniNameFromAttributes(TypeDefinition). What happens if the TypeDefinition does not implement IJniNameProviderAttribute?

In particular, Creator<T> does not implement IJniNameProviderAttribute -- nor should it.

If the TypeDefinition (typeof(Creator<>)) does not implement IJniNameProviderAttribute, then JavaNativeTypeManager.ToJniNameFromAttributes(TypeDefinition) will return null, which means JavaNativeTypeManager.ToJniName(TypeDefinition) will return java/lang/Object, which explains the new signature you're seeing for InitializeCreator().

...which doesn't actually make sense; shouldn't the IJavaObject check in JavaNativeTypeManager.ToJniName(TypeDefinition, ExportKind) catch Creator<T>? In which case we should be hitting ToJniName<T>(), which should create the md5.../Creator_1 name.

More digging is needed. :-(

Commit dotnet@cb161d2 introduced a regression described in dotnet/android#1149 (comment) The signature of the `InitializeCreator` method was wrongly calculated as `()Ljava/lang/Object;` instead of original `()Lmd59b7a7576784821ea63294fbca8600da1/Creator_1;` The reason for that is, that dotnet@cb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR262 started using `IEnumerable<T>::OfType<T>`, which traverses inheritance, unlike the original `Type::GetCustomAttributes` called with `inherit = false`. Thus for the `Creator<Player>` we got the `RegisterAttribute` from the parent type `Java.Lang.Object` which led to non-null result from `ToJniNameFromAttributes` method. At the end the result was used here dotnet@cb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR361 instead of returning `ToJniName (type, exportKind)` result.

Fixes: dotnet/android#1149 Commit cb161d2 broke the use of `[Java.Interop.ExportAttribute]` and `[Java.Interop.ExportFieldAttribute]`. Repro: 1. [Create a class with an `[Export]` or `[ExportField]` method][0]: partial class MyParcelable : Java.Lang.Object, IParcelable { [ExportField ("CREATOR")] public static MyParcelableCreator InitializeCreator () { /* ... */ } } 2. Launch the app, and cause the `MyParcelable` Java Callable Wrapper (JCW) to be initialized: // Will eventually cause JCW MyParcelable.class to be init'd var whatever = new MyParcelable(); Expected result: It works! Actual result: System.InvalidOperationException: Specified managed method 'InitializeCreator' was not found. Signature: ()Lmd5<<whatever>>/MyParcelableCreator; at Android.Runtime.JNIEnv.RegisterJniNatives (System.IntPtr typeName_ptr, System.Int32 typeName_len, System.IntPtr jniClass, System.IntPtr methods_ptr, System.Int32 methods_len) [0x001d2] in <36a2bb1be1a64b51b22cbef15eee5437>:0 at (wrapper managed-to-native) Java.Interop.NativeMethods.java_interop_jnienv_alloc_object(intptr,intptr&,intptr) at Java.Interop.JniEnvironment+Object.AllocObject (Java.Interop.JniObjectReference type) [0x00027] in <8e80eb3ca41f4c3eb745bd7c73458796>:0 at Java.Interop.JniType.AllocObject () [0x0000c] in <8e80eb3ca41f4c3eb745bd7c73458796>:0 at Java.Interop.JniPeerMembers+JniInstanceMethods.StartCreateInstance (System.String constructorSignature, System.Type declaringType, Java.Interop.JniArgumentValue* parameters) [0x0003e] in <8e80eb3ca41f4c3eb745bd7c73458796>:0 at Java.Lang.Object..ctor () [0x00034] in <36a2bb1be1a64b51b22cbef15eee5437>:0 ... [0]: https://github.com/xamarin/monodroid-samples/blob/f944f42001fa134915069fa7bbb9cb493bfd446d/ExportAttribute/ExportAttributeTest/MainActivity.cs#L52-L86 The `InvalidOperationException` is thrown from [`JNIEnv.RegisterJniNatives()` for `__export__` methods][reg], which requires that `JavaNativeTypeManager.GetJniSignature(MethodInfo)` return the same value as what the Java Callable Wrapper contains. [reg]: https://github.com/xamarin/xamarin-android/blob/master/src/Mono.Android/Android.Runtime/JNIEnv.cs#L172-L178 Rephrased: we require that the Reflection-based `JavaNativeTypeManager.GetJniSignature(MethodInfo)` generate identical values as the Cecil-based `JavaNativeTypeManager.GetJniSignature(MethodDefinition)`: the former used by `JNIEnv.RegisterJniNatives()`, the latter by `JavaCallableWrapperGenerator`. These *must* be consistent. The problem is, they weren't: `JavaNativeTypeManager.ToJniNameFromAttributes(Type)` -- called by `JavaNativeTypeManager.GetJniSignature(MethodInfo)` and others -- was erroneously updated to check for custom attributes on the specified `Type` *and all base classes*. Checking base classes would eventually cause `Java.Lang.Object` to be checked, causing *everything* to become `java.lang.Object` unless explicitly overridden in the inheritance chain (e.g. `Activity`, which has its own `[Register]` attribute). The result is that `JavaNativeTypeManager.GetJniSignature(MethodInfo)` for `MyParcelable.InitializeCreator()` was returning: ()Ljava/lang/Object; while `JavaNativeTypeManager.GetJniSignature(MethodDefinition)` was generating: ()Lmd5<<whatever>>/MyParcelableCreator; Because these didn't match, `InvalidOperationException` was thrown. Fix `JavaNativeTypeManager.ToJniNameFromAttributes(Type)` so that base classes are *not* searched for custom attributes, restoring prior behavior.

Fixes: dotnet#1149 Adds support for `$(JI_MAX_JDK)` (not yet used). Fix many, *many*, Gendarme warnings in `Java.Interop.dll`.

Fixes: dotnet#1149

Fixes: #1149 Adds support for `$(JI_MAX_JDK)` (not yet used). Fix many, *many*, Gendarme warnings in `Java.Interop.dll`.

Fixes: #1149

fullmetaltac · 2018-01-09T15:38:51Z

Fix Verified. Issue in not reproduced.

MP91 · 2019-11-14T09:41:20Z

Hi @ALL!
I am using Visual Studio for Mac and still have this error. I am on the latest stable release (16-3).
Is there anything I have to do?

Fixes: xamarin/monodroid#1147 Changes: http://github.com/xamarin/monodroid/compare/27736a7ffc48d606ab45598f761e873f8572f46a...daa2fb6ca52ecfd0884177da5b57501bb4dda3c6 * xamarin/monodroid@daa2fb6ca: Bump to xamarin/xamarin-analysis@9524531 (#1149) * xamarin/monodroid@bca44d592: [tools/msbuild] <FastDeploy/> Length cannot be less than zero (#1148) * xamarin/monodroid@2df384fe2: [tools/msbuild] improve XA0010 error message (#1144) * xamarin/monodroid@b2da84d5f: [tools/msbuild] remove MSBuild targets related to the Xamarin Inspector (#1143)

jonpryor added the Area: App Runtime Issues in `libmonodroid.so`. label Jan 2, 2018

jonpryor assigned radekdoulik Jan 2, 2018

jonpryor added the regression label Jan 2, 2018

jonpryor added this to the d15-6 milestone Jan 2, 2018

This was referenced Jan 8, 2018

[Java.Interop] Fix JNI signature generating dotnet/java-interop#248

Closed

[Java.Interop] Fix JNI signature generating dotnet/java-interop#249

Merged

jonpryor closed this as completed in dotnet/java-interop@d8862d8 Jan 9, 2018

jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Jan 9, 2018

Bump to Java.Interop/master/d8862d89

2b24179

Fixes: dotnet#1149 Adds support for `$(JI_MAX_JDK)` (not yet used). Fix many, *many*, Gendarme warnings in `Java.Interop.dll`.

jonpryor mentioned this issue Jan 9, 2018

Bump to Java.Interop/master/d8862d89 #1166

Merged

jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Jan 9, 2018

Bump to Java.Interop/d15-6/eb6e3c4f

c665935

Fixes: dotnet#1149

jonpryor mentioned this issue Jan 9, 2018

Bump to Java.Interop/d15-6/eb6e3c4f #1167

Merged

jonpryor added a commit that referenced this issue Jan 9, 2018

Bump to Java.Interop/master/d8862d89 (#1166)

304d6f3

Fixes: #1149 Adds support for `$(JI_MAX_JDK)` (not yet used). Fix many, *many*, Gendarme warnings in `Java.Interop.dll`.

jonpryor added a commit that referenced this issue Jan 9, 2018

Bump to Java.Interop/d15-6/eb6e3c4f (#1167)

737c2b0

Fixes: #1149

pjcollins added the verified label Jan 9, 2018

This was referenced Jan 25, 2018

Java invocation failure with master/15.6 #1187

Closed

JNI DETECTED ERROR IN APPLICATION: can't make objects of type android.support.v4.app.FragmentPagerAdapter #1216

Closed

MP91 mentioned this issue Jan 9, 2020

Can not Export CREATOR Field for IParcelable instance #3923

Closed

ghost locked as resolved and limited conversation to collaborators Jun 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can not Export CREATOR Field for IParcelable instance #1149

Can not Export CREATOR Field for IParcelable instance #1149

fullmetaltac commented Jan 2, 2018 •

edited

Loading

jonpryor commented Jan 2, 2018

fullmetaltac commented Jan 3, 2018

fullmetaltac commented Jan 3, 2018 •

edited

Loading

radekdoulik commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

jonpryor commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

jonpryor commented Jan 8, 2018

fullmetaltac commented Jan 9, 2018

MP91 commented Nov 14, 2019

Can not Export CREATOR Field for IParcelable instance #1149

Can not Export CREATOR Field for IParcelable instance #1149

Comments

fullmetaltac commented Jan 2, 2018 • edited Loading

Sample link

Issue description

Steps to reproduce the issue

What's the expected result?

What's the actual result?

Steps to reproduce the issue

What's the expected result?

What's the actual result?

Additional details / screenshot (Optional)

jonpryor commented Jan 2, 2018

fullmetaltac commented Jan 3, 2018

fullmetaltac commented Jan 3, 2018 • edited Loading

radekdoulik commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

jonpryor commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

radekdoulik commented Jan 8, 2018

jonpryor commented Jan 8, 2018

fullmetaltac commented Jan 9, 2018

MP91 commented Nov 14, 2019

fullmetaltac commented Jan 2, 2018 •

edited

Loading

fullmetaltac commented Jan 3, 2018 •

edited

Loading