[Java.Interop] Fix JNI signature generating #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dotnet@cb161d2 introduced a regression described in dotnet/android#1149 (comment) The signature of the `InitializeCreator` method was wrongly calculated as `()Ljava/lang/Object;` instead of original `()Lmd59b7a7576784821ea63294fbca8600da1/Creator_1;` The reason for that is, that dotnet@cb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR262 started using `IEnumerable<T>::OfType<T>`, which traverses inheritance, unlike the original `Type::GetCustomAttributes` called with `inherit = false`. Thus for the `Creator<Player>` we got the `RegisterAttribute` from the parent type `Java.Lang.Object` which led to non-null result from `ToJniNameFromAttributes` method. At the end the result was used here dotnet@cb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR361 instead of returning `ToJniName (type, exportKind)` result.
|
Commit from master cherry-picked as eb6e3c4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
cb161d2
introduced a regression described in
dotnet/android#1149 (comment)
The signature of the
InitializeCreatormethod was wrongly calculatedas
()Ljava/lang/Object;instead of original()Lmd59b7a7576784821ea63294fbca8600da1/Creator_1;The reason for that is, that
cb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR262
started using
IEnumerable<T>::OfType<T>, which traversesinheritance, unlike the original
Type::GetCustomAttributescalledwith
inherit = false.Thus for the
Creator<Player>we got theRegisterAttributefrom theparent type
Java.Lang.Objectwhich led to non-null result fromToJniNameFromAttributesmethod. At the end the result was used herecb161d2#diff-9e153905b02dbe50c0e0b874ba40bf3eR361
instead of returning
ToJniName (type, exportKind)result.