[One .NET] Target net6.0 instead of netcoreapp3.1 #5891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects which were multitargetd to support .NET 6 have been updated to target `net6.0` instead of `netcoreapp3.1`. CI has been updated to install .NET 6 preview 3 instead of .NET 5.
|
This depends on dotnet/android-tools#118 |
jonathanpeppers
pushed a commit
to dotnet/android-tools
that referenced
this pull request
Apr 29, 2021
Context: dotnet/android#5891 I've been hitting errors running tests locally on Windows after building with .NET 6 Preview 3: Error Message: System.IO.FileNotFoundException : Could not load file or assembly 'System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Stack Trace: at Xamarin.ProjectTools.DotNetXamarinProject.SaveProject() at Xamarin.ProjectTools.XamarinProject.Save(Boolean saveProject) in C:\Users\Peter\source\xamarin-android\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.ProjectTools\Common\XamarinProject.cs:line 241 at Xamarin.ProjectTools.ProjectBuilder.Save(XamarinProject project, Boolean doNotCleanupOnUpdate, Boolean saveProject) in C:\Users\Peter\source\xamarin-android\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.ProjectTools\Common\ProjectBuilder.cs:line 43 at Xamarin.ProjectTools.ProjectBuilder.Build(XamarinProject project, Boolean doNotCleanupOnUpdate, String[] parameters, Boolean saveProject, Dictionary`2 environmentVariables) in C:\Users\Peter\source\xamarin-android\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.ProjectTools\Common\ProjectBuilder.cs:line 67 at Xamarin.Android.Build.Tests.WearTests.ResolveLibraryImportsWithReadonlyFiles() in C:\Users\Peter\source\xamarin-android\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.Android.Build.Tests\WearTests.cs:line 28 Rather than copying the version of the MSBuild assemblies used to build our test projects to the output directory, we should be able to use the NuGet package content directly. These files should only be used by our project creation APIs and as a result their version shouldn't matter.
jonathanpeppers
approved these changes
Apr 29, 2021
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to dotnet/java-interop
that referenced
this pull request
May 3, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
May 5, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin/xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0. Update all appropriate `$(TargetFrameworks)` values so that `net6.0` is used instead of `netcoreapp3.1`. Update `global.json` so that a Prerelease .NET 6 SDK is used, and use `boots` to install the preview version of Mono which supports targeting `net6.0`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects which were multitargeted to support .NET 6 have been updated
to target
net6.0instead ofnetcoreapp3.1. CI has been updated toinstall .NET 6 preview 3 instead of .NET 5.