[build] target net6.0 instead of netcoreapp3.1 #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
net6.0
branch
4 times, most recently
from
4a5e671 to
55b2eb5
Compare
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Apr 30, 2021
jonathanpeppers
force-pushed
the
net6.0
branch
4 times, most recently
from
f8d3840 to
a4faf0f
Compare
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Apr 30, 2021
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Apr 30, 2021
Context: dotnet/android#5891 Context: dotnet/android@e59f649 xamarin-android should imminently be building libraries targeting `net6.0` instead of `netcoreapp3.1`. We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
May 3, 2021
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
May 3, 2021
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
May 3, 2021
|
This is green! dotnet/android#5895 |
jpobst
approved these changes
May 3, 2021
|
This also seems to add several new NRT-related warnings to the build, but they can be fixed later in a separate PR. |
jonpryor
reviewed
May 4, 2021
| NOTE: in xamarin-android, this project gets built by xabuild in Xamarin.Android-Tests.sln | ||
| Exclude net6.0, because xabuild cannot build net5.0 or higher | ||
| --> | ||
| <PropertyGroup Condition=" '$(XABuild)' == 'true' "> |
There was a problem hiding this comment.
What sets $(XABuild)? I don't see any "obvious" references within xamarin-android:
% git grep '\<XABuild\>'
tools/xabuild/XABuild.cs: class XABuild
Is this via some MSBuild magic?
There was a problem hiding this comment.
It is magic, this XML file we generate presets MSBuild properties:
So I made any xabuild invocation set this property by default.
There was a problem hiding this comment.
Context: https://github.com/xamarin/xamarin-android/pull/5891
Context: https://github.com/xamarin/xamarin-android/commit/e59f6493fedd789cbd3157d369104516cfffd3f0
xamarin/xamarin-android should imminently be building libraries
targeting `net6.0` instead of `netcoreapp3.1`.
We should be able to do this now, because Mono 6.12.0.137 supports
building both .NET 5.0 and .NET 6.0.
Update all appropriate `$(TargetFrameworks)` values so that `net6.0`
is used instead of `netcoreapp3.1`.
Update `global.json` so that a Prerelease .NET 6 SDK is used, and use
`boots` to install the preview version of Mono which supports
targeting `net6.0`. |
This was referenced May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5891
Context: dotnet/android@e59f649
xamarin-android should imminently be building libraries targeting
net6.0instead ofnetcoreapp3.1.We should be able to do this now, because Mono 6.12.0.137 supports building both .NET 5.0 and .NET 6.0.