[Java.Interop] Fix NRT warnings introduced by targeting 'net6.0'. #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #829 we began targeting
net6.0instead ofnetcoreapp3.1. This framework contains additional nullable annotations that resulted in new warnings.One problem with fixing these is that we needed to make
typenot-nullable here, which means removing the default type. However removing the default type meant the parameter had to be moved before other parameter(s) with a default type.https://github.com/xamarin/java.interop/blob/main/src/Java.Interop/Java.Interop/JniValueMarshaler.cs#L145
I am not very familiar with this code, so I do not know if there are side-effects of changing this, or if this is considered "public API" which cannot be changed?