Skip to content

Build with net5.0 TFM instead of netcoreapp3.1 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

radekdoulik
Copy link
Member

That would allow use of new NET5 API like the new dynamic dependency
attribute

@radekdoulik
Copy link
Member Author

This PR is draft as it needs newer msbuild 16.8, which will be available in the next VS 2019 release.

@jpobst
Copy link
Contributor

jpobst commented Jan 7, 2021

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

Comment on lines +9 to +15
arguments: '-v:diag -c $(Build.Configuration) -target:Prepare'

- task: DotNetCoreCLI@2
displayName: Build Solution
inputs:
projects: Java.Interop.sln
arguments: '-c $(Build.Configuration) -m:1'
arguments: '-v:diag -c $(Build.Configuration) -m:1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might go ahead and add a -bl:prepare.binlog and -bl:build.binlog and upload these as artifacts.

@jpobst
Copy link
Contributor

jpobst commented Jan 7, 2021

Looks like this is blocked by mono/mono#20250. Given the lack of activity there, we may need to come up with a workaround.

@jonathanpeppers
Copy link
Member

@jpobst this is somewhat terrible, but you could try using VS Mac's MSBuild:

mono /Applications/Visual\ Studio.app/Contents/Resources/lib/monodevelop/bin/MSBuild/Current/bin/MSBuild.dll -version

I have VS Mac 8.9 Preview, and it has MSBuild 16.8.

Otherwise, you'll have to use dotnet build for net5.0 on Mac.

@jpobst
Copy link
Contributor

jpobst commented Jan 7, 2021

We have dotnet build working for .net5.0 on Mac for Java.Interop, so that's not a problem. (It's one of the build lanes.)

However, that isn't going to help when Java.Interop gets built as part of XA on Mac. We're going to have to port all of the XA build system to get that to work. 😞

Base automatically changed from master to main January 22, 2021 20:46
@jonathanpeppers
Copy link
Member

Closing this in favor of #829, I think we have a version of Mono we'll be able to do this now, but we should go straight to net6.0.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants