-
Notifications
You must be signed in to change notification settings - Fork 58
Build with net5.0 TFM instead of netcoreapp3.1 #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That would allow use of new NET5 API like the new dynamic dependency [attribute](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.dynamicdependencyattribute?view=net-5.0).
This PR is draft as it needs newer msbuild 16.8, which will be available in the next VS 2019 release. |
Co-authored-by: Jonathan Peppers <[email protected]>
...until the situation around NET defines clears out. Contex: dotnet/designs#165
To `@(Sources)`.
This reverts commit 5efdc96.
/azp run |
Pull request contains merge conflicts. |
arguments: '-v:diag -c $(Build.Configuration) -target:Prepare' | ||
|
||
- task: DotNetCoreCLI@2 | ||
displayName: Build Solution | ||
inputs: | ||
projects: Java.Interop.sln | ||
arguments: '-c $(Build.Configuration) -m:1' | ||
arguments: '-v:diag -c $(Build.Configuration) -m:1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might go ahead and add a -bl:prepare.binlog
and -bl:build.binlog
and upload these as artifacts.
Looks like this is blocked by mono/mono#20250. Given the lack of activity there, we may need to come up with a workaround. |
@jpobst this is somewhat terrible, but you could try using VS Mac's MSBuild:
I have VS Mac 8.9 Preview, and it has MSBuild 16.8. Otherwise, you'll have to use |
We have However, that isn't going to help when Java.Interop gets built as part of XA on Mac. We're going to have to port all of the XA build system to get that to work. 😞 |
Closing this in favor of #829, I think we have a version of Mono we'll be able to do this now, but we should go straight to net6.0. |
That would allow use of new NET5 API like the new dynamic dependency
attribute