Skip to content

Reference the minified js files from templates #11700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkArtakMSFT opened this issue Jun 28, 2019 · 2 comments
Closed

Reference the minified js files from templates #11700

mkArtakMSFT opened this issue Jun 28, 2019 · 2 comments
Assignees
@ryanbrandenburg
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview8

Comments

@mkArtakMSFT
Copy link
Contributor

After we've removed the environment tag helpers, we ended up referencing the raw js files directly. Instead, we should have referenced the minified files.
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. PRI: 1 - Required area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 28, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jun 28, 2019
@isaacrlevin
Copy link
Contributor

My bad, I'll fix

@isaacrlevin isaacrlevin mentioned this issue Jul 1, 2019
Merged
@isaacrlevin
Copy link
Contributor

@mkArtakMSFT fix is in one of my PR

@isaacrlevin isaacrlevin mentioned this issue Jul 9, 2019
Merged
@ryanbrandenburg ryanbrandenburg added Done This issue has been fixed and removed Working labels Jul 10, 2019
ryanbrandenburg added a commit that referenced this issue Jul 10, 2019
@ryanbrandenburg
Merge pull request #12014 from isaac2004/11700-work
6b421fe 
Reference the minified js files from templates #11700
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
3 participants
@isaacrlevin @ryanbrandenburg @mkArtakMSFT