Reference the minified js files from templates #11700 #12014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge Co-authored-by: David Fowler <[email protected]> Co-authored-by: Pranav K <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Co-authored-by: Justin Kotalik <[email protected]> Co-authored-by: Kristian Hellang <[email protected]> Co-authored-by: Ajay Bhargav Baaskaran <[email protected]> Co-authored-by: null <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Hao Kung <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Chris Ross <[email protected]> Co-authored-by: Thomas Levesque <[email protected]>
|
@ryanbrandenburg failed flaky tests |
ryanbrandenburg
approved these changes
Jul 10, 2019
|
The helix tests are not actually required to pass in order to merge. That said these failed to run, so I'd like to wait and make sure they don't surface anything relevant to this PR now that I've retried them. |
Pilchie
added
the
area-mvc
|
Oh, apparently there's a helix outage/problem at the moment, so those are unlikely to succeed. AspNetCore-ci covers the templating tests anyway, we should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Addresses #11700