Skip to content

Disabled Nullability tests #11828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wtgodbe opened this issue Jul 3, 2019 · 1 comment · Fixed by #12202
Closed

Disabled Nullability tests #11828

wtgodbe opened this issue Jul 3, 2019 · 1 comment · Fixed by #12202
Assignees
@rynowak
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Milestone
3.0.0-preview8

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Jul 3, 2019 •
edited
Loading

#11818 disables the following tests due to ingesting the new Roslyn compiler, which changes some nullability metadata:

CanUseNonNullableReferenceType_WithController_OmitData_ValidationErrors
BindProperty_WithNonNullableReferenceType_NoData_ValidationError
BindProperty_WithNonNullableReferenceType_NoData_ValidationError_CustomMessage
BindParameter_WithNonNullableReferenceType_NoData_ValidationError
CreateValidationMetadata_InfersRequiredAttribute_NoNonNullableProperty
IsNonNullable_FindsNonNullableProperty
IsNonNullable_FindsNonNullableParameter

We should look into what's needed to re-enable these.

CC @dougbu @rynowak
@wtgodbe wtgodbe mentioned this issue Jul 3, 2019
Merged
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 3, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview8 milestone Jul 3, 2019
rynowak added a commit that referenced this issue Jul 15, 2019
@rynowak
Fix nullable detection
00b152e 
Fixes: #11828 and #11813
@rynowak rynowak mentioned this issue Jul 15, 2019
Merged
rynowak added a commit that referenced this issue Jul 16, 2019
@rynowak
Fix nullable detection
554456c 
Fixes: #11828 and #11813
@rynowak
Copy link
Member

rynowak commented Jul 17, 2019

Fixed by: #12202

@rynowak rynowak added the Done This issue has been fixed label Jul 17, 2019
rynowak added a commit that referenced this issue Jul 17, 2019
@rynowak
Fix nullable detection (#12202)
4ba66f0 
* Fix nullable detection

Fixes: #11828 and #11813
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Projects
None yet
Milestone
3.0.0-preview8
Development

Successfully merging a pull request may close this issue.

Fix nullable detection dotnet/aspnetcore
4 participants
@Eilon @rynowak @wtgodbe @mkArtakMSFT