Skip to content

Explicitly reference Roslyn compiler toolset version that will ship in preview 7 #11818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2019
Merged

Explicitly reference Roslyn compiler toolset version that will ship in preview 7 #11818

merged 4 commits into from
Jul 3, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jul 2, 2019

@dougbu
Explicitly reference Roslyn compiler toolset version that will ship i…
af18f15 
…n preview 7

- see also dotnet/efcore#16370 and dotnet/efcore#16385 discussions
- grab latest from the '.NET Core 3 Release' channel
@dougbu dougbu requested review from a team, pranavkm, rynowak and wtgodbe July 2, 2019 22:27
wtgodbe
wtgodbe approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once again please ACK when you've added the subscription

@dougbu
Copy link
Contributor Author

dougbu commented Jul 2, 2019

@pranavkm and @rynowak should I skip the 6 tests that are failing in 'master' (see #11744)? If not, which likely will be fine?

@dougbu
Copy link
Contributor Author

dougbu commented Jul 2, 2019

@wtgodbe new subscription for 'release/3.0-preview7' is '57fb441b-6285-4828-9e09-08d6fb351674'

Tests are failing and I'll skip them as soon as I'm sure we know the full set.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 3, 2019
@rynowak
Copy link
Member

rynowak commented Jul 3, 2019

@dougbu - go ahead and skip tests. I'll address the bug after the change is merged.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 3, 2019

@rynowak do you mean we can merge with the failing tests, or is there some commit we can cherry-pick to skip the failing tests?

@wtgodbe wtgodbe mentioned this pull request Jul 3, 2019
Closed
@wtgodbe
Copy link
Member

wtgodbe commented Jul 3, 2019

Issue to track disabled tests: #11828

@wtgodbe
Copy link
Member

wtgodbe commented Jul 3, 2019

@dougbu I've switched to MicrosoftNetCompilersToolsetPackageVersion as this can't be merged without CodeCheck passing, and I've verified locally that darc updates still work with that property name.

@wtgodbe wtgodbe merged commit 23a6e3e into release/3.0-preview7 Jul 3, 2019
@ghost ghost deleted the dougbu/update.compiler branch July 3, 2019 03:49
@dougbu
Copy link
Contributor Author

dougbu commented Jul 3, 2019

Thanks for the added commits @wtgodbe Looks good❕

@dougbu dougbu mentioned this pull request Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

@rynowak rynowak Awaiting requested review from rynowak

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dougbu @rynowak @wtgodbe @Eilon