Skip to content

[master] Update dependencies from dotnet/arcade #11744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2019
Merged

[master] Update dependencies from dotnet/arcade #11744

merged 3 commits into from
Jul 5, 2019

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 1, 2019 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190701.4
  • Date Produced: 7/1/2019 9:33 PM
  • Commit: 1fb1e240c889cd7f6e10cb1eacd129efa3ddb4b4
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19351.4
    • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19351.4
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19351.4

Update dependencies from https://github.com/dotnet/arcade build 20190…
7066ba7 
…630.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19330.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19330.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19330.1
@dotnet-maestro dotnet-maestro bot requested review from dougbu and a team as code owners July 1, 2019 12:04
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 1, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-helix-test (Tests: Helix ARM64), AspNetCore-helix-test (Tests: Helix x64), AspNetCore-ci (Test: Ubuntu 16.04 x64), AspNetCore-ci (Test: macOS 10.13), AspNetCore-ci (Test: Windows Server 2016 x64), AspNetCore-ci (Build: Linux Musl x64), AspNetCore-ci (Build: Linux ARM64), AspNetCore-ci (Build: Linux Musl ARM64), AspNetCore-ci (Build: Linux x64), AspNetCore-ci (Build: Linux ARM), AspNetCore-ci (Code check), AspNetCore-ci (Build: macOS)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 1, 2019
@dougbu
Copy link
Contributor

dougbu commented Jul 1, 2019

Need a newer Arcade, containing the dotnet/arcade#3211 fix (a new SourceLink package). I was previously considering doing something different but this PR is standalone and can wait.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 2, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: AspNetCore-ci (Test: macOS 10.13), AspNetCore-ci (Test: Ubuntu 16.04 x64), AspNetCore-ci (Build: Windows x64/x86)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

Update dependencies from https://github.com/dotnet/arcade build 20190…
be90747 
…701.4

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19351.4
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19351.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19351.4
@dougbu
Copy link
Contributor

dougbu commented Jul 2, 2019

Hopefully the new test failures are flaky tests and not something else coming in from Arcade. Will check back in the morning…

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 2, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: AspNetCore-ci (Test: Windows Server 2016 x64), AspNetCore-ci (Test: macOS 10.13), AspNetCore-ci (Test: Ubuntu 16.04 x64), AspNetCore-ci (Build: Windows x64/x86)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Jul 2, 2019

Kind-of good news: The current issues relate to the new Roslyn compiler version that the Arcade SDK brings in. @rynowak can you please help me out with the failures in

  • CanUseNonNullableReferenceType_WithController_OmitData_ValidationErrors
  • BindProperty_WithNonNullableReferenceType_NoData_ValidationError
  • BindParameter_WithNonNullableReferenceType_NoData_ValidationError
  • CreateValidationMetadata_InfersRequiredAttribute_NoNonNullableProperty
  • IsNonNullable_FindsNonNullableParameter
  • IsNonNullable_FindsNonNullableProperty

See https://dev.azure.com/dnceng/public/_build/results?buildId=247007&view=ms.vss-test-web.build-test-results-tab for more information.

@dougbu
Copy link
Contributor

dougbu commented Jul 2, 2019

@pranavkm @rynowak should these 6 tests also be skipped with a reference to #11813 ?

@dougbu dougbu mentioned this pull request Jul 2, 2019
Merged
@dougbu
Copy link
Contributor

dougbu commented Jul 3, 2019

Should build fine once #11784 is in

@dougbu
Copy link
Contributor

dougbu commented Jul 5, 2019

@HaoK @JunTaoLuo it looks like the Helix build for this PR (https://dev.azure.com/dnceng/public/_build/results?buildId=252780) is hanging. Is this something we've seen before?

@MattGal if you're around, should have about 2 hours before AzDO cancels this build.

@dougbu dougbu merged commit 3146b77 into master Jul 5, 2019
@ghost ghost deleted the darc-master-d0ad99e0-2ff6-4740-b404-0521021d2f99 branch July 5, 2019 19:18
@MattGal
Copy link
Member

MattGal commented Jul 8, 2019

@dougbu my apologies, was on vacation and couldn't look. This IS very strange, as there don't seem to be any useful logs persisted from this timeout. Any chance they were there when it was happening and you persisted some?

EIther way I'm no longer on vacation and happy to research this strange thing. Given it's happened to you more than once without a log I strongly suspect there's something unusual at play.

@dougbu
Copy link
Contributor

dougbu commented Jul 8, 2019

Any chance they were there when it was happening and you persisted some?

If AzDO didn't save anything, I've got nothing. Is it even possible to retrieve bin logs from Helix agents then upload them as build artifacts? Failing that, how 'bout saving all of the /TestResults files from the agents?

@JunTaoLuo any ideas on how to get more info out of our Helix tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @MattGal @mkArtakMSFT