Skip to content

Improving dev workflow alignment with contributor guidelines for sub-areas with additional requirements #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 4 tasks
JunTaoLuo opened this issue Jul 10, 2019 · 5 comments
Closed
2 of 4 tasks

Improving dev workflow alignment with contributor guidelines for sub-areas with additional requirements #12030

JunTaoLuo opened this issue Jul 10, 2019 · 5 comments
Assignees
@JunTaoLuo
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Milestone
3.0.0-preview9

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jul 10, 2019 •
edited
Loading

Currently our general contributor guidelines do not work in all sub-areas such as Components which have additional requirements. The proposal is to make these additional requirements more visible and the guidelines for working in these areas more explicit and reliable. To this end, some of the following suggestions and/or issues have been raised:

  • Create/Update the build.cmd/sh in the sub areas to ensure required dependencies are built and required tools are available.
  • Stop checking in JS artifacts from Web.JS in Components and compile the artifacts at build time. This should make Components builds more in line with the rest of the repo Build blazor.*.js in CI; don't commit the artifacts #11592
  • Add CI configurations to test a the often-broken developer workflows: Add CI configurations for build.cmd in sub-areas #12029
  • Update our contribution guidelines to include the different requirements (Yarn, NodeJS, Java, etc) need to build the sub-areas and how to restore/build/test.
@JunTaoLuo JunTaoLuo added area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Jul 10, 2019
@rynowak
Copy link
Member

rynowak commented Jul 10, 2019

@jkotalik

@JunTaoLuo JunTaoLuo self-assigned this Jul 10, 2019
@JunTaoLuo JunTaoLuo added this to the 3.0.0-preview8 milestone Jul 10, 2019
This was referenced Jul 11, 2019
Closed
Merged
This was referenced Jul 16, 2019
Closed
Closed
@JunTaoLuo
Copy link
Contributor Author

Remaining work item tracked in #12029 but this issue is mostly addressed

@JunTaoLuo JunTaoLuo added Done This issue has been fixed and removed Working labels Jul 26, 2019
@jkotalik
Copy link
Contributor

@JunTaoLuo good stuff!

@JunTaoLuo JunTaoLuo added 1 - Ready and removed Done This issue has been fixed labels Jul 29, 2019
@JunTaoLuo JunTaoLuo reopened this Jul 29, 2019
@JunTaoLuo
Copy link
Contributor Author

Had to revert the change so I'm re-opening the issue

@dougbu dougbu added Working and removed 1 - Ready labels Aug 2, 2019
@JunTaoLuo
Copy link
Contributor Author

An updated implementation is merged in #12744.

@JunTaoLuo JunTaoLuo added Done This issue has been fixed and removed Working labels Aug 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
4 participants
@rynowak @JunTaoLuo @dougbu @jkotalik