Improve components infrastructure #12024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a cool description? What do you expect to be fixed/improved by this change? |
|
Haven't decided on the full extent of what I will address in this PR and how to break it up yet. Will add details as I go. |
|
ok dope. Looking forward to more details. |
analogrelay
added
area-blazor
|
I'm going to limit this change to fix the common workflows in Components only and will address other sub-areas (native, templates, etc) separately. I still need to test some more scenarios, pack, test, building when yarn isn't installed, etc, so expect a few more small changes. |
rynowak
reviewed
Jul 11, 2019
src/Components/Blazor/testassets/HostedInAspNet.Client/HostedInAspNet.Client.csproj
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Jul 11, 2019
src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj
Outdated
Show resolved
Hide resolved
JunTaoLuo
commented
Jul 11, 2019
| @@ -11,7 +11,7 @@ | |||
| Importance="High" | |||
| Text="Prerequisites were not enforced at build time. Running Yarn or the E2E tests might fail as a result. Check /src/Shared/E2ETesting/Readme.md for instructions." /> | |||
|
|
|||
| <Yarn Command="install --mutex network" /> | |||
| <Yarn Command="install --mutex network" Condition="'$(EnforceE2ETestPrerequisites)' == 'true'"/> | |||
There was a problem hiding this comment.
WIP, I think this will break some dev workflows. Don't check this in yet.
added 8 commits
July 11, 2019 12:49
This is just working around the issue
JunTaoLuo
force-pushed
the
johluo/components
branch
3 times, most recently
from
b926cf5 to
7c73b91
Compare
|
I'm going to create another PR, I have no idea why the CI isn't building this branch anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12030
A few of the workflows I'm trying to improve: