You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is working for us. The idea is that if we need to expose functionality to CiruitHandler then we'll add those methods on Circuit. I don't see anything to change here.
LOL
Make WasmMediaTypeNames internal.
Prerendering
Move RemoteRendererException to M.A.Components.Server
Why does RemoteUriHelper need to be public? This doesn't seem good.
Find out why we need the HttpContext in ComponentPrerenderingContext (good reasons)
I don't feel like any of these APIs are elegant and cool, but the usage here is really for infrastructure (between MVC and components). I don't feel a need to polish these to a mirror sheen because they will scale well.
I think the argument could be made here to move these to a separate namespace. If you count RRE then that's 4 types that would live there.
Part of: #12221
This was part of a previous PR, but I accidentally removed it during a
rebase :(
Server/ref/Microsoft.AspNetCore.Components.Server.netcoreapp3.0.cs
Part of: #12221
This was part of a previous PR, but I accidentally removed it during a
rebase :(
Server/ref/Microsoft.AspNetCore.Components.Server.netcoreapp3.0.cs
ghost
locked as resolved and limited conversation to collaborators
Dec 3, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-blazorIncludes: Blazor, Razor ComponentsDoneThis issue has been fixed
Summary
These are miscellaneous types from the
M.A.Components.Server
assembly that aren't used in startup code.Circuits
LOL
Prerendering
The text was updated successfully, but these errors were encountered: