Blazor API Review: Misc M.A.Components.Server #12260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ public void ConfigureServices(IServiceCollection services) | |||
| options.MimeTypes = ResponseCompressionDefaults.MimeTypes.Concat(new[] | |||
| { | |||
| MediaTypeNames.Application.Octet, | |||
| WasmMediaTypeNames.Application.Wasm | |||
| "application/wasm", | |||
There was a problem hiding this comment.
A string literal? You can do that??
There was a problem hiding this comment.
That's not enough indirection, please make a static property backed by a constant.
There was a problem hiding this comment.
You've just been visited by the #LiteralGang - upvote 20 times or else you have to take everything literally for a week.
SteveSandersonMS
approved these changes
Jul 17, 2019
javiercn
reviewed
Jul 17, 2019
rynowak
force-pushed
the
rynowak/server-misc-api-review
branch
from
ae2b6b6 to
7bf9aef
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #12221