Skip to content

DefaultReconnectionHandler "invokes failed if reconnect fails" test fails on macOS #12578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JunTaoLuo opened this issue Jul 25, 2019 · 4 comments
Closed

DefaultReconnectionHandler "invokes failed if reconnect fails" test fails on macOS #12578

JunTaoLuo opened this issue Jul 25, 2019 · 4 comments
Assignees
@NTaylorMullen
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed test-failure
Milestone
3.0.0-preview9

Comments

@JunTaoLuo
Copy link
Contributor

As part of #12145, I found that "invokes failed if reconnect fails" fails on macOS consistently. I've disabled it (commented it out) for now but the failure should be investigated.
@JunTaoLuo JunTaoLuo added 1 - Ready test-failure area-blazor Includes: Blazor, Razor Components labels Jul 25, 2019
@JunTaoLuo
Copy link
Contributor Author

cc @rynowak @SteveSandersonMS @javiercn @pranavkm

@SteveSandersonMS
Copy link
Member

Thanks @JunTaoLuo!

@JunTaoLuo JunTaoLuo mentioned this issue Jul 26, 2019
Merged
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 26, 2019
@mkArtakMSFT mkArtakMSFT removed their assignment Jul 26, 2019
@mkArtakMSFT
Copy link
Contributor

@NTaylorMullen here is another one for you to tackle.

@NTaylorMullen
Copy link

I can't reproduce the failure on MacOS. Going to relax some of the test parameters and see if it passes on the CI.

NTaylorMullen pushed a commit that referenced this issue Aug 13, 2019
Re-enable reconnection failed invocation validation test.
3415789 
- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
@NTaylorMullen NTaylorMullen mentioned this issue Aug 13, 2019
Merged
NTaylorMullen pushed a commit that referenced this issue Aug 14, 2019
Re-enable reconnection failed invocation validation test.
d12caa5 
- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
NTaylorMullen pushed a commit that referenced this issue Aug 14, 2019
Re-enable reconnection failed invocation validation test.
e5a950d 
- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed Working labels Aug 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed test-failure
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
4 participants
@SteveSandersonMS @NTaylorMullen @JunTaoLuo @mkArtakMSFT