Skip to content

Re-enable reconnection failed invocation validation test. #13105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

NTaylorMullen
Copy link

  • Relaxed the maxRetries and retryIntervalMilliseconds parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578

@NTaylorMullen NTaylorMullen added area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode labels Aug 13, 2019
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works?

Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @pranavkm said, merge if it succeeds.

@rynowak
Copy link
Member

rynowak commented Aug 14, 2019

    ● DefaultReconnectionHandler › invokes failed if reconnect fails
  
      expect(jest.fn()).toHaveBeenCalledTimes(3)
  
      Expected mock function to have been called three times, but it was called two times.
  
        74 |     expect(testDisplay.show).toHaveBeenCalled();
        75 |     expect(testDisplay.failed).toHaveBeenCalled();
      > 76 |     expect(reconnect).toHaveBeenCalledTimes(3);
           |                       ^
        77 |   });
        78 | });
        79 | 
  
        at Object.<anonymous> (tests/DefaultReconnectionHandler.test.ts:76:23)
        at step (tests/DefaultReconnectionHandler.test.ts:32:23)
        at Object.next (tests/DefaultReconnectionHandler.test.ts:13:53)
        at fulfilled (tests/DefaultReconnectionHandler.test.ts:4:58)
  

@rynowak
Copy link
Member

rynowak commented Aug 14, 2019

Seems relevant?

- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants