Skip to content

Refactor SignalR Transports Errors #34765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TanayParikh opened this issue Jul 27, 2021 · 0 comments · Fixed by #34766
Closed

Refactor SignalR Transports Errors #34765

TanayParikh opened this issue Jul 27, 2021 · 0 comments · Fixed by #34766
Assignees
@TanayParikh
Labels
area-blazor Includes: Blazor, Razor Components Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-server
Milestone
6.0-rc1

Comments

@TanayParikh
Copy link
Contributor

Error classes should go in https://github.com/dotnet/aspnetcore/blob/main/src/SignalR/clients/ts/signalr/src/Errors.ts

Originally posted by @BrennanConroy in #34644 (comment)

Extension of #34644
TanayParikh added a commit that referenced this issue Jul 27, 2021
@TanayParikh
Refactor SignalR Transports Errors
0cd1ddd 
Fixes: #34765
@TanayParikh TanayParikh mentioned this issue Jul 27, 2021
Merged
@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together feature-blazor-server enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Jul 27, 2021
@TanayParikh TanayParikh self-assigned this Jul 27, 2021
@TanayParikh TanayParikh added this to the 6.0-rc1 milestone Jul 27, 2021
@ghost ghost added the Working label Jul 27, 2021
TanayParikh added a commit that referenced this issue Jul 28, 2021
@TanayParikh
Refactor SignalR Transports Errors (#34766)
6eaba08 
* Refactor SignalR Transports Errors

Fixes: #34765

* PR Feedback

* PR Feedback
@ghost ghost added Done This issue has been fixed and removed Working labels Jul 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
@TanayParikh
Refactor SignalR Transports Errors (#34766)
1e248ec 
* Refactor SignalR Transports Errors

Fixes: dotnet/aspnetcore#34765

* PR Feedback

* PR Feedback
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
area-blazor Includes: Blazor, Razor Components Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-server
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging a pull request may close this issue.

Refactor SignalR Transports Errors dotnet/aspnetcore
1 participant
@TanayParikh