Refactor SignalR Transports Errors #34766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
requested review from
BrennanConroy,
halter73 and
a team
as code owners
TanayParikh
added
area-blazor
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| // Everything that users need to access must be exported here. Including interfaces. | |||
| export { AbortSignal } from "./AbortController"; | |||
| export { AbortError, HttpError, TimeoutError } from "./Errors"; | |||
| export { AbortError, HttpError, TimeoutError, AggregateErrors, DisabledTransportError, FailedToStartTransportError, UnsupportedTransportError } from "./Errors"; | |||
There was a problem hiding this comment.
These shouldn't be exported unless you want to bring them to API review
There was a problem hiding this comment.
If it's just for this one use case, may not make much sense to expose all these additional types (especially considering they aren't comprehensive on all potential HttpConnection exceptions). Updated 666db5a.
BrennanConroy
approved these changes
Jul 28, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34765