Skip to content

AsyncValidationAttribute #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GeorgePetri opened this issue Jun 22, 2018 · 4 comments
Closed

AsyncValidationAttribute #4897

GeorgePetri opened this issue Jun 22, 2018 · 4 comments
Assignees
@danroth27
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating. Needs: Spec Indicates that a spec defining user experience is required
Milestone
Backlog

Comments

@GeorgePetri
Copy link

As others have said #786, #7791, I think adding AsyncValidationAttribute would be beneficial.

This feature would allow doing non blocking validation logic in the attributes which are highly composable and reusable.

Thanks
@mkArtakMSFT
Copy link
Member

Thanks for bringing this up, @GeorgePetri. This is an interesting ask and we're definitely interested in this. While that's not an immediate priority, we're moving this out the the Backlog so we can evaluate it later on.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Mvc Dec 14, 2018
@aspnet-hello aspnet-hello assigned danroth27 and unassigned danroth27 Dec 14, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview2 milestone Dec 14, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating. Needs: Spec Indicates that a spec defining user experience is required labels Dec 14, 2018
@scalablecory
Copy link
Contributor

Is there any progress on this?

I began working on this, but found I needed to make a large amount of changes and code duplication due to the amount of synchronous public interfaces that are involved in validation.

I'm not comfortable making such sweeping changes without input first -- if one of the .NET crew is able to provide some direction, I'd be happy to put in the work. Is duplication the best path, or is it okay to make this a breaking change to keep things cleaner?

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview3, Backlog Feb 13, 2019
@mkArtakMSFT
Copy link
Member

We've moved this issue to the Backlog milestone. This means that it is not going to happen for the coming release. We will reassess the backlog following the current release and consider this item at that time. However, keep in mind that there are many other high priority features with which it will be competing for resources.

@pranavkm pranavkm added the c label Aug 22, 2019
@mkArtakMSFT
Copy link
Member

Thanks for contacting us. We're closing this issue as there was no community involvement here for quite a while now.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danroth27 danroth27

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating. Needs: Spec Indicates that a spec defining user experience is required
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@pranavkm @danroth27 @scalablecory @GeorgePetri @mkArtakMSFT @aspnet-hello