Skip to content

Disable CORS functional tests from running in parallel #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2019
Merged

Disable CORS functional tests from running in parallel #7791

merged 4 commits into from
Feb 21, 2019

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm requested a review from Tratcher as a code owner February 21, 2019 14:28
pranavkm and others added 3 commits February 21, 2019 09:06
@pranavkm
Throw if CORS policy is configured to allow credentials and any origin (
51e2bea 
#7751)

* Throw if CORS policy is configured to allow credentials and any origin

Fixes #3106
@natemcmaster
Targeting pack and shared framework fixups (#7794)
6252351 
* Fix package type to match spec ('DotnetPlatform')
* Fix missing metadata in MSI installer
* Fix incorrect target order which caused duplicate assemblies in netcore.app and aspnetcore.app
@natemcmaster
Always kill processes and remove direct reference to component govern…
fbaa3e8 
…ance task (#7793)
@natemcmaster natemcmaster requested a review from dougbu as a code owner February 21, 2019 17:29
dougbu
dougbu approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I hope the other commits in this PR go away when you rebase

@natemcmaster natemcmaster merged commit fbaa3e8 into master Feb 21, 2019
@GeorgePetri GeorgePetri mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @dougbu @natemcmaster