Always kill processes and remove direct reference to component governance task #7793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance task Component governance is automatically configured for all builds now
|
By the way, this is what I mean by "automatically configured". A post-build step is added automatically on all builds running in dnceng.
|
dougbu
approved these changes
Feb 21, 2019
| # Detect OSS Components in use in the product. Only needs to run on one OS in the matrix. | ||
| - task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0 | ||
| displayName: Detect components | ||
| condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false)) |
There was a problem hiding this comment.
Nice to know about the new build step 😸
Eilon
approved these changes
Feb 21, 2019
dougbu
reviewed
Feb 21, 2019
| _kill git.exe | ||
| _kill vctip.exe | ||
| _kill chrome.exe | ||
| _kill h2spec.exe |
There was a problem hiding this comment.
What does this really change? The failure message taskkill spits out wasn't horrendous.
There was a problem hiding this comment.
The default view in AzDO shows all stderr messages (even though we are ignoring them). I'm trying to address this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7777
Component governance is automatically configured for all builds now.
cc @Eilon - targeting release/3.0-preview3 because this is affecting builds on all branches