Skip to content

Always kill processes and remove direct reference to component governance task #7793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Always kill processes and remove direct reference to component governance task #7793

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c739f1
Always kill processes and remove direct reference to component govern…
Feb 21, 2019
a98c676
Gracefully run taskkill
Feb 21, 2019
7c3d9ff
fixup! Gracefully run taskkill
Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions eng/scripts/KillProcesses.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
$ErrorActionPreference = 'Continue'

taskkill /T /F /IM dotnet.exe
taskkill /T /F /IM testhost.exe
taskkill /T /F /IM iisexpress.exe
taskkill /T /F /IM iisexpresstray.exe
taskkill /T /F /IM w3wp.exe
taskkill /T /F /IM msbuild.exe
taskkill /T /F /IM vbcscompiler.exe
taskkill /T /F /IM git.exe
taskkill /T /F /IM vctip.exe
taskkill /T /F /IM chrome.exe
taskkill /T /F /IM h2spec.exe
function _kill($processName) {
try {
& cmd /c "taskkill /T /F /IM $processName 2>&1"
} catch {
Write-Host "Failed to kill $processName: $_"
}
}

_kill dotnet.exe
_kill testhost.exe
_kill iisexpress.exe
_kill iisexpresstray.exe
_kill w3wp.exe
_kill msbuild.exe
_kill vbcscompiler.exe
_kill git.exe
_kill vctip.exe
_kill chrome.exe
_kill h2spec.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this really change? The failure message taskkill spits out wasn't horrendous.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default view in AzDO shows all stderr messages (even though we are ignoring them). I'm trying to address this:

image

iisreset /restart

exit 0