Skip to content

Update the health check endpoint route builder extensions to make the endpoint display name configurable. #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CBaud opened this issue Mar 9, 2019 · 1 comment
Labels
area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo)

Comments

@CBaud
Copy link
Contributor

CBaud commented Mar 9, 2019

Is your feature request related to a problem? Please describe.

In ASP.NET Core 3.0 Preview 3, the health check endpoint route builder extensions specify a common display name ("Health checks") for all health check endpoints.

Describe the solution you'd like

It would be helpful if the extensions allowed the display name to be configurable by the service. For example, a service running on Kubernetes may have two separate health check endpoints for the liveness and readiness probes.

Describe alternatives you've considered

The alternative would be to manually configure the health check endpoints in my service.

CBaud added a commit to CBaud/AspNetCore that referenced this issue Mar 9, 2019
@Eilon Eilon added the area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) label Mar 11, 2019
rynowak pushed a commit that referenced this issue Mar 12, 2019
@CBaud CBaud closed this as completed Mar 14, 2019
@rynowak
Copy link
Member

rynowak commented Mar 15, 2019

Thanks @CBaud

FYI I'm not sure you saw my follow up PR - we decided to make this part of the builder returned from MapHealthChecks. So this is uniform across all endpoint routing stuff and won't be missed when we add future router-ware. Just mentioning because we ended up not going with your fix. I'm glad that you made the effort and I don't want you to think we don't appreciate it.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo)
Projects
None yet
Development

No branches or pull requests

3 participants