Skip to content

Update the health check endpoint route builder extensions to make the endpoint display name configurable. (#8359) #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

CBaud
Copy link
Contributor

@CBaud CBaud commented Mar 9, 2019

This updates the health check endpoint route builder extensions to make the display name configurable.

Addresses #8359

@CBaud CBaud requested a review from Tratcher as a code owner March 9, 2019 01:35
@CBaud
Copy link
Contributor Author

CBaud commented Mar 9, 2019

FYI @JamesNK @rynowak

@Eilon Eilon added the area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) label Mar 11, 2019
@rynowak
Copy link
Member

rynowak commented Mar 12, 2019

Looks good, thanks Chris thanks!

We may end up changing this to use a builder .AddHealthChecks(...).WithDisplayName(...) to make it consistent with some other routing stuff.

I'm going to accept this PR for now since it's an improvement.

@rynowak rynowak merged commit 77948fe into dotnet:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants