Skip to content

Insert seed localization for templates. #11040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2019
Merged

Insert seed localization for templates. #11040

merged 4 commits into from
Jul 30, 2019

Conversation

phenning
Copy link
Contributor

@phenning phenning commented Jun 10, 2019 •
edited
Loading

Description

Localization seeding for the new localization mechanism for dotnet template engine templates in Visual Studio. Generated based on host file metadata in the templates and the localized strings we have in Visual Studio.

Customer impact

This is for the new localization mechanism for templates which is shipping in 16.3, allowing us to decouple localization from Visual Studio.

Regression?
No, this PR got missed merging for preview8.

Risk
Very low.

@phenning
Copy link
Contributor Author

phenning commented Jun 10, 2019 •
edited
Loading

The goal here is to eventually have all the localization be generated directly from your repos, but this starts to move us in that direction with the current translations statically checked in.

@ryanbrandenburg, we will need to refresh this again after the other template changes which are still pending. After those changes are in, I'll do another PR.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 10, 2019
@mkArtakMSFT mkArtakMSFT added the blocked The work on this issue is blocked due to some dependency label Jun 17, 2019
@ryanbrandenburg ryanbrandenburg removed the blocked The work on this issue is blocked due to some dependency label Jun 28, 2019
@ryanbrandenburg ryanbrandenburg added this to the 3.0.0-preview8 milestone Jun 28, 2019
@mkArtakMSFT
Copy link
Contributor

This is not blocked any more, as I've heard no concerns regarding this.

@danroth27 danroth27 mentioned this pull request Jun 29, 2019
Merged
@ryanbrandenburg ryanbrandenburg requested a review from danroth27 July 1, 2019 17:01
@phenning
Copy link
Contributor Author

@anurse, @mkArtakMSFT
I just updated this PR with the latest translations and refactoring in the repo. Can we get this merged into master before the noon branching?

@mkArtakMSFT
Copy link
Contributor

@phenning please rebase this to release/3.0 branch (which is where all preview 9 changes go) and we'll merge it in there.

@analogrelay
Copy link
Contributor

I don't have any concerns about this, but I also don't have a lot of context. Seems good to me :).

@phenning phenning changed the base branch from master to release/3.0 July 30, 2019 19:46
@phenning
Copy link
Contributor Author

@phenning please rebase this to release/3.0 branch (which is where all preview 9 changes go) and we'll merge it in there.

Rebased and retargetted.

@mkArtakMSFT mkArtakMSFT added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Jul 30, 2019
@mkArtakMSFT mkArtakMSFT merged commit b2e11d7 into dotnet:release/3.0 Jul 30, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks @phenning. This is approved so I merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu left review comments

@danroth27 danroth27 danroth27 approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it.
Projects
None yet
Milestone
3.0.0-preview9
Development

Successfully merging this pull request may close these issues.
7 participants
@phenning @mkArtakMSFT @analogrelay @danroth27 @dougbu @Eilon @ryanbrandenburg