Remove package guids from client-side Blazor templates #11707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-mvc
mkArtakMSFT
approved these changes
Jun 30, 2019
ghost
deleted the
|
Hi @danroth27 , is there any guideline on how to do this? (removing the package GUIDs from the VS host files for the blazor client templates) cc @guardrex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11706
The client-side Blazor templates currently show up with the same name and description in VS 16.3 P1. This is because the updated localization content for these templates already went into 16.3 before the work to rename and refactor the templates was done (see #10348).
We worked with the web tools folks on a resolution and the recommended workaround for this issue is to remove the package GUIDs from the VS host files for these templates. This will cause the localized content in VS to not be used for these templates and instead the strings from the templates will be used. This was tested and verified with the help of @phenning.
After the localized template content is moved to this repo (see #11040) we can reenable localization for these templates in VS.
/cc @vijayrkn