Rename Configure -> Attach #12266
Merged
Rename Configure -> Attach #12266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jul 17, 2019
| @@ -149,7 +149,7 @@ public class TestLayout : IComponent | |||
| [Parameter] | |||
| RenderFragment Body { get; set; } | |||
|
|
|||
| public void Configure(RenderHandle renderHandle) | |||
| public void Attach(RenderHandle renderHandle) | |||
There was a problem hiding this comment.
Attach seems better to me than AttachToRenderer because Render is already in the parameter list.
SteveSandersonMS
approved these changes
Jul 17, 2019
Part of: #11610
rynowak
force-pushed
the
rynowak/IComponent
branch
from
2f21698 to
e222b11
Compare
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #11610