Skip to content

Rename Configure -> Attach #12266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Rename Configure -> Attach #12266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Blazor/Build/test/DirectiveRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public class TestLayout : IComponent
[Parameter]
RenderFragment Body { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attach seems better to me than AttachToRenderer because Render is already in the parameter list.

{
}

Expand Down
8 changes: 4 additions & 4 deletions src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.Manual.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public CascadingValue() { }
public string Name { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
[Microsoft.AspNetCore.Components.ParameterAttribute]
public T Value { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
public void Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public System.Threading.Tasks.Task SetParametersAsync(Microsoft.AspNetCore.Components.ParameterCollection parameters) { throw null; }
}

Expand All @@ -114,7 +114,7 @@ public PageDisplay() { }
public System.Type Page { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
[Microsoft.AspNetCore.Components.ParameterAttribute]
public System.Collections.Generic.IDictionary<string, object> PageParameters { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
public void Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public System.Threading.Tasks.Task SetParametersAsync(Microsoft.AspNetCore.Components.ParameterCollection parameters) { throw null; }
}
}
Expand Down Expand Up @@ -255,7 +255,7 @@ public NavLink() { }
public RenderFragment ChildContent { get; set; }
[Microsoft.AspNetCore.Components.ParameterAttribute]
public Microsoft.AspNetCore.Components.Routing.NavLinkMatch Match { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
public void Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Dispose() { }
public System.Threading.Tasks.Task SetParametersAsync(Microsoft.AspNetCore.Components.ParameterCollection parameters) { throw null; }
}
Expand All @@ -271,7 +271,7 @@ public Router() { }
public Microsoft.AspNetCore.Components.RenderFragment<AuthenticationState> NotAuthorizedContent { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
[Microsoft.AspNetCore.Components.ParameterAttribute]
public Microsoft.AspNetCore.Components.RenderFragment AuthorizingContent { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } private set { throw null; }}
public void Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
public void Dispose() { }
protected virtual void Render(Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder, System.Type handler, System.Collections.Generic.IDictionary<string, object> parameters) { }
public System.Threading.Tasks.Task SetParametersAsync(Microsoft.AspNetCore.Components.ParameterCollection parameters) { throw null; }
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public ComponentBase() { }
protected virtual void BuildRenderTree(Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder) { }
protected System.Threading.Tasks.Task InvokeAsync(System.Action workItem) { throw null; }
protected System.Threading.Tasks.Task InvokeAsync(System.Func<System.Threading.Tasks.Task> workItem) { throw null; }
void Microsoft.AspNetCore.Components.IComponent.Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
void Microsoft.AspNetCore.Components.IComponent.Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle) { }
System.Threading.Tasks.Task Microsoft.AspNetCore.Components.IHandleAfterRender.OnAfterRenderAsync() { throw null; }
System.Threading.Tasks.Task Microsoft.AspNetCore.Components.IHandleEvent.HandleEventAsync(Microsoft.AspNetCore.Components.EventCallbackWorkItem callback, object arg) { throw null; }
protected virtual void OnAfterRender() { }
Expand Down Expand Up @@ -361,7 +361,7 @@ public static partial class EventHandlers
}
public partial interface IComponent
{
void Configure(Microsoft.AspNetCore.Components.RenderHandle renderHandle);
void Attach(Microsoft.AspNetCore.Components.RenderHandle renderHandle);
System.Threading.Tasks.Task SetParametersAsync(Microsoft.AspNetCore.Components.ParameterCollection parameters);
}
public partial interface IComponentContext
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/CascadingValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class CascadingValue<T> : ICascadingValueComponent, IComponent
bool ICascadingValueComponent.CurrentValueIsFixed => IsFixed;

/// <inheritdoc />
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/ComponentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ protected Task InvokeAsync(Action workItem)
protected Task InvokeAsync(Func<Task> workItem)
=> _renderHandle.Dispatcher.InvokeAsync(workItem);

void IComponent.Configure(RenderHandle renderHandle)
void IComponent.Attach(RenderHandle renderHandle)
{
// This implicitly means a ComponentBase can only be associated with a single
// renderer. That's the only use case we have right now. If there was ever a need,
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Components/src/IComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ namespace Microsoft.AspNetCore.Components
public interface IComponent
{
/// <summary>
/// Initializes the component.
/// Attaches the component to a <see cref="RenderHandle" />.
/// </summary>
/// <param name="renderHandle">A <see cref="RenderHandle"/> that allows the component to be rendered.</param>
void Configure(RenderHandle renderHandle);
void Attach(RenderHandle renderHandle);

/// <summary>
/// Sets parameters supplied by the component's parent in the render tree.
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/PageDisplay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class PageDisplay : IComponent
public RenderFragment AuthorizingContent { get; private set; }

/// <inheritdoc />
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/Rendering/Renderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private ComponentState AttachAndInitComponent(IComponent component, int parentCo
var componentState = new ComponentState(this, componentId, component, parentComponentState);
Log.InitializingComponent(_logger, componentState, parentComponentState);
_componentStateById.Add(componentId, componentState);
component.Configure(new RenderHandle(this, componentId));
component.Attach(new RenderHandle(this, componentId));
return componentState;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/Routing/Router.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public class Router : IComponent, IHandleAfterRender, IDisposable
private RouteTable Routes { get; set; }

/// <inheritdoc />
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_logger = LoggerFactory.CreateLogger<Router>();
_renderHandle = renderHandle;
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Components/test/CascadingParameterStateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ static CascadingValue<T> CreateCascadingValueComponent<T>(T value, string name =
{
var supplier = new CascadingValue<T>();
var renderer = new TestRenderer();
supplier.Configure(new RenderHandle(renderer, 0));
supplier.Attach(new RenderHandle(renderer, 0));

var supplierParams = new Dictionary<string, object>
{
Expand Down Expand Up @@ -424,7 +424,7 @@ class ComponentWithNamedCascadingParam : TestComponentBase

class TestComponentBase : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> throw new NotImplementedException();

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down
6 changes: 3 additions & 3 deletions src/Components/Components/test/ComponentFactoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private static IServiceProvider GetServiceProvider()

private class EmptyComponent : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
throw new NotImplementedException();
}
Expand All @@ -125,7 +125,7 @@ private class ComponentWithInjectProperties : IComponent

public TestService2 GetProperty2() => Property2;

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
throw new NotImplementedException();
}
Expand All @@ -143,7 +143,7 @@ private class ComponentWithNonInjectableProperties : IComponent

public TestService1 Property2 { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
throw new NotImplementedException();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/DependencyInjectionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class TestComponent : IComponent
// not throw, then be sure also to add a test to verify that injection
// occurs before lifecycle methods.

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> throw new NotImplementedException();

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/EventCallbackFactoryBinderExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ public Task HandleEventAsync(EventCallbackWorkItem item, object arg)
return item.InvokeAsync(arg);
}

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
throw new System.NotImplementedException();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/EventCallbackFactoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ public Task SomeFuncTTask(string s)
return Task.CompletedTask;
}

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
throw new NotImplementedException();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/EventCallbackTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ public Task HandleEventAsync(EventCallbackWorkItem item, object arg)
return item.InvokeAsync(arg);
}

public void Configure(RenderHandle renderHandle) => throw new NotImplementedException();
public void Attach(RenderHandle renderHandle) => throw new NotImplementedException();

public Task SetParametersAsync(ParameterCollection parameters) => throw new NotImplementedException();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/ParameterCollectionAssignmentExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ public ParameterCollection Build()

class FakeComponent : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> throw new NotImplementedException();

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/ParameterCollectionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ public IEnumerable<Parameter> ToEnumerable(ParameterCollection parameterCollecti

private class FakeComponent : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> throw new NotImplementedException();

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/RenderTreeBuilderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,7 @@ public void ProcessDuplicateAttributes_CanRemoveOverwrittenAttributes()

private class TestComponent : IComponent
{
public void Configure(RenderHandle renderHandle) { }
public void Attach(RenderHandle renderHandle) { }

public Task SetParametersAsync(ParameterCollection parameters)
=> throw new NotImplementedException();
Expand Down
10 changes: 5 additions & 5 deletions src/Components/Components/test/RenderTreeDiffBuilderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2221,7 +2221,7 @@ private class FakeComponent : IComponent

public string NonParameterProperty { get; set; }

public void Configure(RenderHandle renderHandle) { }
public void Attach(RenderHandle renderHandle) { }
public Task SetParametersAsync(ParameterCollection parameters)
{
parameters.SetParameterProperties(this);
Expand All @@ -2231,7 +2231,7 @@ public Task SetParametersAsync(ParameterCollection parameters)

private class FakeComponent2 : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
}

Expand All @@ -2242,7 +2242,7 @@ private class CaptureSetParametersComponent : IComponent
{
public int SetParametersCallCount { get; private set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
}

Expand All @@ -2258,14 +2258,14 @@ private class DisposableComponent : IComponent, IDisposable
public int DisposalCount { get; private set; }
public void Dispose() => DisposalCount++;

public void Configure(RenderHandle renderHandle) { }
public void Attach(RenderHandle renderHandle) { }

public Task SetParametersAsync(ParameterCollection parameters) => Task.CompletedTask;
}

private class NonDisposableComponent : IComponent
{
public void Configure(RenderHandle renderHandle) { }
public void Attach(RenderHandle renderHandle) { }

public Task SetParametersAsync(ParameterCollection parameters) => Task.CompletedTask;
}
Expand Down
12 changes: 6 additions & 6 deletions src/Components/Components/test/RendererTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3399,7 +3399,7 @@ public TestComponent(RenderFragment renderFragment)
_renderFragment = renderFragment;
}

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down Expand Up @@ -3470,7 +3470,7 @@ private class FakeComponent : IComponent

public RenderHandle RenderHandle { get; private set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> RenderHandle = renderHandle;

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down Expand Up @@ -3619,7 +3619,7 @@ private class RendersSelfAfterEventComponent : IComponent, IHandleEvent

private RenderHandle _renderHandle;

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> _renderHandle = renderHandle;

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down Expand Up @@ -3650,7 +3650,7 @@ private class MultiRendererComponent : IComponent
private readonly List<RenderHandle> _renderHandles
= new List<RenderHandle>();

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> _renderHandles.Add(renderHandle);

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down Expand Up @@ -3764,7 +3764,7 @@ public AsyncComponent(Task taskToAwait, int number)

public int Number { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandler = renderHandle;
}
Expand Down Expand Up @@ -3806,7 +3806,7 @@ public void SomeMethod()
SomeMethodCallCount++;
}

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down
6 changes: 3 additions & 3 deletions src/Components/Components/test/Rendering/HtmlRendererTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ private class ComponentWithParameters : IComponent
{
public RenderHandle RenderHandle { get; private set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
RenderHandle = renderHandle;
}
Expand Down Expand Up @@ -553,7 +553,7 @@ private class ChildComponent : IComponent
{
private RenderHandle _renderHandle;

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down Expand Up @@ -584,7 +584,7 @@ private class TestComponent : IComponent
[Inject]
public RenderFragment Fragment { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Server/test/Circuits/CircuitHostTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ public void Dispose()
private class ThrowOnDisposeComponent : IComponent, IDisposable
{
public bool DidCallDispose { get; private set; }
public void Configure(RenderHandle renderHandle) { }
public void Attach(RenderHandle renderHandle) { }

public Task SetParametersAsync(ParameterCollection parameters)
=> Task.CompletedTask;
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Server/test/Circuits/CircuitPrerendererTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class UriDisplayComponent : IComponent

[Inject] IUriHelper UriHelper { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand All @@ -242,7 +242,7 @@ public Task SetParametersAsync(ParameterCollection parameters)

class ThrowExceptionComponent : IComponent
{
public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
=> throw new InvalidTimeZoneException();

public Task SetParametersAsync(ParameterCollection parameters)
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Server/test/Circuits/RemoteRendererTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ public TestComponent(RenderFragment renderFragment)

public Action OnAfterRenderComplete { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down Expand Up @@ -325,7 +325,7 @@ private class AutoParameterTestComponent : IComponent

[Parameter] public Trigger Trigger { get; set; }

public void Configure(RenderHandle renderHandle)
public void Attach(RenderHandle renderHandle)
{
_renderHandle = renderHandle;
}
Expand Down
Loading