Skip to content

Improvements to MVC EventData typess #12323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Improvements to MVC EventData typess #12323

merged 1 commit into from
Jul 19, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jul 18, 2019

Improvments to names

  • Using EventData suffix
  • More clarity for events assocated with filters

Fixes: #12263

@rynowak rynowak added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 18, 2019
@rynowak rynowak requested a review from pranavkm July 18, 2019 20:39
@rynowak rynowak force-pushed the rynowak/event-data branch from 55ab987 to 1a4a2d2 Compare July 18, 2019 23:47
Improvments to names
- Using EventData suffix
- More clarity for events assocated with filters

Fixes: #12263

We have to report the BeforeActionMethod using its old signature because
it's used by Intellitrace. I added a new pair of events with a better
name to use with strong types since there's no practical way to update
the old ones.
@rynowak rynowak force-pushed the rynowak/event-data branch from 1a4a2d2 to 959ad94 Compare July 19, 2019 17:32
@rynowak rynowak merged commit b23ea5b into master Jul 19, 2019
@ghost ghost deleted the rynowak/event-data branch July 19, 2019 19:53
@mkArtakMSFT mkArtakMSFT added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVC DiagnosticListener changes break Intellitrace
3 participants