Improvements to MVC EventData typess #12323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
added
the
area-mvc
pranavkm
approved these changes
Jul 18, 2019
rynowak
force-pushed
the
rynowak/event-data
branch
from
55ab987 to
1a4a2d2
Compare
mkArtakMSFT
approved these changes
Jul 19, 2019
Improvments to names - Using EventData suffix - More clarity for events assocated with filters Fixes: #12263 We have to report the BeforeActionMethod using its old signature because it's used by Intellitrace. I added a new pair of events with a better name to use with strong types since there's no practical way to update the old ones.
rynowak
force-pushed
the
rynowak/event-data
branch
from
1a4a2d2 to
959ad94
Compare
ghost
deleted the
mkArtakMSFT
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvments to names
Fixes: #12263