Update branding to 3.0.1 #14404
Update branding to 3.0.1 #14404
Conversation
dougbu
commented
Sep 25, 2019
dougbu
commented
- aspnet/AspNetCore-Internal#3153
dougbu
added
the
feature-platform
- aspnet/AspNetCore-Internal#3153
- add `$(IgnorePackageBaselines)` property
- no changes in known frameworks, targeting pack features, et cetera
dougbu
force-pushed
the
dougbu/branding.3.0.1
branch
from
03f3540 to
2d9d13a
Compare
Either the targeting pack is not written anymore or its path changed. Both would be an unintended side effect of my changes. |
|
That's unrelated to this change. It's happening on a bunch of PRs. @JunTaoLuo and I think it might be an agent issue. |
| @@ -36,7 +36,8 @@ | |||
| --> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsServicingBuild)' != 'true' ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' != 'true' ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' == 'true' AND ( '$(IsServicingBuild)' != 'true' OR '$(IsPackable)' == 'true' ) ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences | |||
| Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' == 'true' AND '$(IsPackable)' == 'true' ">true</UseLatestPackageReferences> | |||
There was a problem hiding this comment.
Remaining changes in this file just address nits. Removed of '$(IsServicingBuild)' != 'true' OR because that's already checked 2 lines above.
Well, exit code 9009 means "file not found". If it's an agent issue, that would mean @BrennanConroy thanks, this makes more sense than my thought the targeting pack itself wasn't found. The command creates the .tar.gz file from files in its current directory. |
- `$(IsServicingBuild)` disabled at the moment
|
This is ready to go once |
dougbu
force-pushed
the
dougbu/branding.3.0.1
branch
from
e79b82c to
ec2fed0
Compare
|
🆙📅 to include a more complete dotnet/core-eng#7970 workaround
|
| @@ -86,7 +86,7 @@ | |||
| <TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName> | |||
|
|
|||
| <!-- Used to only produce targeting pack installers/packages once per major.minor. --> | |||
| <IsTargetingPackBuilding Condition="'$(IsServicingBuild)' == 'true' AND '$(DotNetBuildFromSource)' != 'true'">false</IsTargetingPackBuilding> | |||
| <IsTargetingPackBuilding Condition="'$(AspNetCorePatchVersion)' == '0' AND '$(DotNetBuildFromSource)' != 'true'">false</IsTargetingPackBuilding> | |||
There was a problem hiding this comment.
Hmm well, we need to rebuild the targeting pack in 3.0.1 so this logic needs some finessing. We need to be able to control whether the targeting pack builds. We can use this as a default logic though.
| rm variable:global:_DotNetInstallDir -ea Ignore | ||
| rm variable:global:_ToolsetBuildProj -ea Ignore | ||
| rm variable:global:_MSBuildExe -ea Ignore | ||
| Remove-Item variable:global:_BuildTool -ea Ignore |
There was a problem hiding this comment.
Why this change? Looks fine but I'm just curious.
There was a problem hiding this comment.
Because aliases are bad in scripts and VS Code warns about them
- work around dotnet/core-eng#7970 - install Git in repo if Tar can't be found in usual locations - use found or installed Tar in Microsoft.AspNetCore.App.Ref project - copy into repo from wherever it's found - add lots of `Write-Host` debugging nit: clean up / comment on VS Code warnings about build.ps1
dougbu
force-pushed
the
dougbu/branding.3.0.1
branch
from
611331a to
f219a38
Compare
|
Success modulo a missing |
ghost
deleted the
