-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/3.0] Update dependencies from 4 repositories #14425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/3.0] Update dependencies from 4 repositories #14425
Conversation
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Same as dotnet/blazor#1899 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@MattGal the validation pipeline run here uses NetCorePublic-Pool / BuildPool.Windows.10.Amd64.VS2019.Open in both Windows test jobs but only one (running on Agent: NetCorePublic-Pool 74) complained about the MSBuild version. Do the agents now have varying VS versions? @wtgodbe FYI this is blocked by your #14394 and that's blocked by my #14404 and that's still failing |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Pushed the internal build tasks to dotnet-core |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
MSBuild 16.3 thing. Retrying. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Immediately after a rollout (basically until the pool is "idle" for a few minutes) we do have both agents from the old and new images available. There is a way we could prevent this but will involve using our home-grown autoscale implementation, which is not quite ready to back everyone's queues just yet. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
/azp run AspNetCore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run AspNetCore-helix-test |
Azure Pipelines successfully started running 1 pipeline(s). |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@JunTaoLuo please look into the weird source build error:
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@wtgodbe please retry PR validation here after your |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Did you folks get to the bottom of the deps.json issue or are you still using the hacky workaround to SetAppPaths? |
I've sent the diagnostic logs and output to @dsplaisted, any updates on that Daniel? |
9ea129a fixed the template tests! |
@JunTaoLuo looks like your commit fixed all but the helix problems, is it OK to merge that or do we need a less intrusive fix? |
There are a few fixes I need to modify. I'll give the signal when this is ready for review/merge. |
|
||
<!-- Substitute references to Extensions packages with with ref assemblies --> | ||
<ItemGroup Condition="'$(ReferenceReferenceAssemblies)' == 'true' AND '$(TargetFramework)' == 'netcoreapp3.0' AND '$(DisableExtensionsRefAssembliesSwap)' != 'true' "> | ||
<_ExtensionInternalRefAssemblies Include="Microsoft.Extensions.Caching.Abstractions" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to find a way to remove this but so far haven't had any luck.
eng/Versions.props
Outdated
@@ -22,6 +22,8 @@ | |||
<BlazorClientPreReleasePreviewNumber>9</BlazorClientPreReleasePreviewNumber> | |||
<BlazorClientPreReleaseVersionLabel>preview$(BlazorClientPreReleasePreviewNumber)</BlazorClientPreReleaseVersionLabel> | |||
<AspNetCoreMajorMinorVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</AspNetCoreMajorMinorVersion> | |||
<!-- The following property may need to be updated if ingesting new versions of Extensions.Refs package. The package override version is used to create PackageOverrides.txt in the targeting pack. --> | |||
<MicrosoftInternalExtensionsRefsPackageOverrideVersion>3.0.0</MicrosoftInternalExtensionsRefsPackageOverrideVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a good way to calculate this value so I'm keeping this manual for now. It's not a good system and I welcome ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use AspNetCoreBaselineVersion
if this was done in dir.build.props: https://github.com/aspnet/AspNetCore/blob/9783b9e35faecf5976900cce0f698647088294b2/eng/Baseline.Designer.props#L5
@@ -15,6 +15,8 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<Reference Include="Microsoft.AspNetCore.Authorization" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These probably aren't needed now that we use indirectreferences.props. It's quite tedious to remove all of these but might be worth it.
Assuming all the checks come back clean I think this is ready to merge. @wtgodbe please review. I'll double check and compare some artifacts against 3.0.0 versions to see if there are any unintended changes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if the ref/runtime packs compare favorably to 3.0.0, we should take this ASAP to unblock 3.0.1. We need to be very careful to NOT merge this forward to 3.1, though. We should make sure we wait for Doug's fix before we migrate any changes to that branch.
Tests failures are #14425 (comment) again, and again in tests unrelated to the most recent commit. Still don't know what causes this one, but last time it went away after retry |
Oops, sorry about the E2E test break. Hmm I'm seeing some failures with the following pattern:
This seems to be a flakiness in the IndirectReferences logic. I have seen these failures before and they pass on retry. Any idea why this might be happening? |
|
This time the test failure was |
Actually I'm not sure if rerunning the build is going to help, the error is:
@HaoK have you seen this error before? Is node being installed twice? |
Weird, that looks like an issue with cleanup on the build machines - I don't think we should consider that a blocking issue, especially since we've seen every test pass in Helix on either the current or previous test run |
I haven't seen that error before, I can see if there's some hardening we can add to the install node script |
The PR is merged and should unblock 3.0.1 @mmitche . Will file followup issues for things that were not addressed in this PR. |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/aspnet/Blazor
From https://github.com/aspnet/EntityFrameworkCore
From https://github.com/aspnet/AspNetCore-Tooling
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format