Skip to content

[release/3.0] Update dependencies from 4 repositories #14425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 25, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190924.3
  • Date Produced: 9/24/2019 6:16 PM
  • Commit: 0e9ffd6464aff37aef2dc41dc2162d258f266e32
  • Branch: refs/heads/release/3.x
  • Updates:
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19474.3
    • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19474.3
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19474.3

From https://github.com/aspnet/Blazor

  • Build: 20191003.2
  • Date Produced: 10/3/2019 5:24 PM
  • Commit: c606594a0e5ebc36636d36e418ee0e189ce7a012
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.AspNetCore.Blazor.Mono -> 3.0.0-preview9.19503.2

From https://github.com/aspnet/EntityFrameworkCore

  • Build: 20191010.4
  • Date Produced: 10/11/2019 4:20 AM
  • Commit: e2fe2f425e976394d933ad5fcf304fd3de6759f5
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.EntityFrameworkCore.Tools -> 3.0.1
    • Microsoft.EntityFrameworkCore.SqlServer -> 3.0.1
    • dotnet-ef -> 3.0.1
    • Microsoft.EntityFrameworkCore -> 3.0.1
    • Microsoft.EntityFrameworkCore.InMemory -> 3.0.1
    • Microsoft.EntityFrameworkCore.Relational -> 3.0.1
    • Microsoft.EntityFrameworkCore.Sqlite -> 3.0.1

From https://github.com/aspnet/AspNetCore-Tooling

  • Build: 20191007.2
  • Date Produced: 10/7/2019 2:20 PM
  • Commit: ae9d989c74c6f4850df8b612f4a91da87448a181
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.NET.Sdk.Razor -> 3.0.1-servicing.19507.2
    • Microsoft.CodeAnalysis.Razor -> 3.0.1-servicing.19507.2
    • Microsoft.AspNetCore.Razor.Language -> 3.0.1-servicing.19507.2
    • Microsoft.AspNetCore.Mvc.Razor.Extensions -> 3.0.1-servicing.19507.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Microsoft.AspNetCore.Analyzer.Testing -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.AspNetCore.BenchmarkRunner.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.ActivatorUtilities.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Caching.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Caching.Memory -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Caching.SqlServer -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Caching.StackExchangeRedis -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.CommandLineUtils.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.AzureKeyVault -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.Binder -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.CommandLine -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.EnvironmentVariables -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.FileExtensions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.Ini -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.Json -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.KeyPerFile -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.UserSecrets -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration.Xml -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Configuration -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.DependencyInjection.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.DependencyInjection -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.DiagnosticAdapter -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Diagnostics.HealthChecks -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.FileProviders.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.FileProviders.Composite -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.FileProviders.Embedded -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.FileProviders.Physical -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.FileSystemGlobbing -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.HashCodeCombiner.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Hosting.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Hosting -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.HostFactoryResolver.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Http -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Localization.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Localization -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.Abstractions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.AzureAppServices -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.Configuration -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.Console -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.Debug -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.EventSource -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.EventLog -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.TraceSource -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Logging.Testing -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.ObjectPool -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Options.ConfigurationExtensions -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Options.DataAnnotations -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Options -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.ParameterDefaultValue.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.Primitives -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.TypeNameHelper.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.ValueStopwatch.Sources -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.WebEncoders -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.JSInterop -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Mono.WebAssembly.Interop -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.NETCore.App.Runtime.win-x64 -> 3.0.1 (parent: Microsoft.Extensions.Logging)
  • Microsoft.Extensions.Logging -> 3.0.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.Extensions.DependencyModel -> 3.0.1 (parent: Microsoft.Extensions.Logging)
  • Microsoft.NETCore.App.Ref -> 3.0.1 (parent: Microsoft.Extensions.Logging)
  • NETStandard.Library.Ref -> 2.1.0 (parent: Microsoft.Extensions.Logging)
  • Internal.AspNetCore.Analyzers -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)
  • Microsoft.AspNetCore.Testing -> 3.0.1-servicing.19510.1 (parent: Microsoft.EntityFrameworkCore)

@dotnet-maestro dotnet-maestro bot requested review from dougbu and a team as code owners September 25, 2019 16:21
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Ubuntu 16.04 x64), AspNetCore-ci (Build Test: Linux Source Build), AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Test: macOS 10.13), AspNetCore-ci (Build Build: Linux Musl ARM64), AspNetCore-ci (Build Build: Linux Musl x64), AspNetCore-ci (Build Build: Linux ARM64), AspNetCore-ci (Build Build: Linux ARM), AspNetCore-ci (Build Build: Linux x64), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Build: macOS), AspNetCore-ci (Build Build: Windows x64/x86), AspNetCore-ci (Build Code check)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dotnet-maestro dotnet-maestro bot changed the title [release/3.0] Update dependencies from dotnet/arcade [release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor Sep 25, 2019
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 25, 2019
@dotnet-maestro dotnet-maestro bot changed the title [release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor [release/3.0] Update dependencies from 3 repositories Sep 25, 2019
@dotnet-maestro dotnet-maestro bot changed the title [release/3.0] Update dependencies from 3 repositories [release/3.0] Update dependencies from 4 repositories Sep 25, 2019
@wtgodbe
Copy link
Member

wtgodbe commented Sep 25, 2019

/home/vsts/work/1/s/artifacts/toolset/restore.proj : error : Unable to find package Microsoft.DotNet.Arcade.Sdk with version (= 1.0.0-beta.19474.3)

Same as dotnet/blazor#1899

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Sep 26, 2019

@MattGal the validation pipeline run here uses NetCorePublic-Pool / BuildPool.Windows.10.Amd64.VS2019.Open in both Windows test jobs but only one (running on Agent: NetCorePublic-Pool 74) complained about the MSBuild version. Do the agents now have varying VS versions?


@wtgodbe FYI this is blocked by your #14394 and that's blocked by my #14404 and that's still failing ☹️

@dougbu dougbu added the blocked The work on this issue is blocked due to some dependency label Sep 26, 2019
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 26, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Ubuntu 16.04 x64), AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Test: macOS 10.13), AspNetCore-ci (Build Build: Linux Musl ARM64), AspNetCore-ci (Build Build: Linux Musl x64), AspNetCore-ci (Build Build: Linux ARM64), AspNetCore-ci (Build Build: Linux x64), AspNetCore-ci (Build Build: Linux ARM), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Build: macOS), AspNetCore-ci (Build Build: Windows x64/x86), AspNetCore-ci (Build Code check)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@mmitche
Copy link
Member

mmitche commented Sep 26, 2019

Pushed the internal build tasks to dotnet-core

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 26, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Build: Windows x64/x86), AspNetCore-ci (Build Code check)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 27, 2019

MSBuild 16.3 thing. Retrying.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Build: Windows x64/x86), AspNetCore-ci (Build Code check)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@MattGal
Copy link
Member

MattGal commented Sep 30, 2019

@MattGal the validation pipeline run here uses NetCorePublic-Pool / BuildPool.Windows.10.Amd64.VS2019.Open in both Windows test jobs but only one (running on Agent: NetCorePublic-Pool 74) complained about the MSBuild version. Do the agents now have varying VS versions?

@wtgodbe FYI this is blocked by your #14394 and that's blocked by my #14404 and that's still failing ☹️

Immediately after a rollout (basically until the pool is "idle" for a few minutes) we do have both agents from the old and new images available. There is a way we could prevent this but will involve using our home-grown autoscale implementation, which is not quite ready to back everyone's queues just yet.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 30, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Build: Windows x64/x86), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Code check)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

/azp run AspNetCore-helix-test

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 3, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci (Build Test: Linux Source Build)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

@JunTaoLuo please look into the weird source build error:

  Restore completed in 65.66 ms for /__w/1/s/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19474.3/tools/Tools.proj.
/__w/1/s/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj : error : Failed to resolve SDK 'Yarn.MSBuild'. Package restore was successful but a package with the ID of "Yarn.MSBuild" was not installed.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 3, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Linux Source Build), AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Build: Windows x64/x86)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Oct 4, 2019

@wtgodbe please retry PR validation here after your <icon> fix is in 'release/3.0'

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 4, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: AspNetCore-ci, AspNetCore-ci (Build Build: Windows x64/x86)
  • ✔️ No Requested Changes Succeeded - No reviews have requested changes.

@nguerrera
Copy link
Contributor

Did you folks get to the bottom of the deps.json issue or are you still using the hacky workaround to SetAppPaths?

@JunTaoLuo
Copy link
Contributor

I've sent the diagnostic logs and output to @dsplaisted, any updates on that Daniel?

@wtgodbe
Copy link
Member

wtgodbe commented Oct 25, 2019

9ea129a fixed the template tests!

@ryanbrandenburg
Copy link
Contributor

@JunTaoLuo looks like your commit fixed all but the helix problems, is it OK to merge that or do we need a less intrusive fix?

@JunTaoLuo
Copy link
Contributor

There are a few fixes I need to modify. I'll give the signal when this is ready for review/merge.


<!-- Substitute references to Extensions packages with with ref assemblies -->
<ItemGroup Condition="'$(ReferenceReferenceAssemblies)' == 'true' AND '$(TargetFramework)' == 'netcoreapp3.0' AND '$(DisableExtensionsRefAssembliesSwap)' != 'true' ">
<_ExtensionInternalRefAssemblies Include="Microsoft.Extensions.Caching.Abstractions" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to find a way to remove this but so far haven't had any luck.

@@ -22,6 +22,8 @@
<BlazorClientPreReleasePreviewNumber>9</BlazorClientPreReleasePreviewNumber>
<BlazorClientPreReleaseVersionLabel>preview$(BlazorClientPreReleasePreviewNumber)</BlazorClientPreReleaseVersionLabel>
<AspNetCoreMajorMinorVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</AspNetCoreMajorMinorVersion>
<!-- The following property may need to be updated if ingesting new versions of Extensions.Refs package. The package override version is used to create PackageOverrides.txt in the targeting pack. -->
<MicrosoftInternalExtensionsRefsPackageOverrideVersion>3.0.0</MicrosoftInternalExtensionsRefsPackageOverrideVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a good way to calculate this value so I'm keeping this manual for now. It's not a good system and I welcome ideas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -15,6 +15,8 @@
</ItemGroup>

<ItemGroup>
<Reference Include="Microsoft.AspNetCore.Authorization" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These probably aren't needed now that we use indirectreferences.props. It's quite tedious to remove all of these but might be worth it.

@JunTaoLuo
Copy link
Contributor

Assuming all the checks come back clean I think this is ready to merge. @wtgodbe please review. I'll double check and compare some artifacts against 3.0.0 versions to see if there are any unintended changes.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2019

Microsoft.AspNetCore.Components.E2ETests timed out again on Windows, presumably due to ea81866#diff-9866d7dbeef1e74cba14c4ad5e4c78a9L30-L37. When I "fixed" these it was by manually adding a reference to Microsoft.AspNetCore.ResponseCompression: cc350d4. I'm not sure why that manual ref was needed only in this 1 place, but we could fix it by adding that back. Maybe some weirdness around Selenium. Looking at the rest of the PR now, but in general I think we can take some less-than-ideal fixes in the name of unblocking 3.0.1.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if the ref/runtime packs compare favorably to 3.0.0, we should take this ASAP to unblock 3.0.1. We need to be very careful to NOT merge this forward to 3.1, though. We should make sure we wait for Doug's fix before we migrate any changes to that branch.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2019

Tests failures are #14425 (comment) again, and again in tests unrelated to the most recent commit. Still don't know what causes this one, but last time it went away after retry

@JunTaoLuo
Copy link
Contributor

Oops, sorry about the E2E test break.

Hmm I'm seeing some failures with the following pattern:

System.IO.FileLoadException : Could not load file or assembly 'Microsoft.Net.Http.Headers, Version=3.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. An operation is not legal in the current state. (0x80131509)

This seems to be a flakiness in the IndirectReferences logic. I have seen these failures before and they pass on retry. Any idea why this might be happening?

@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2019

InMemory.FunctionalTests-netcoreapp3.0 failed on Helix in the first run

@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2019

This time the test failure was Microsoft.AspNetCore.SpaServices.Extensions.Tests, on Windows7. Seems likely these 2 were flaky as they didn't repeat on the same commit

@JunTaoLuo
Copy link
Contributor

Actually I'm not sure if rerunning the build is going to help, the error is:

Executed on a000WSK

C:\dotnetbuild\work\7b4a08d9-6316-4b2d-9440-e6abbe37e5cb\Work\09d95c30-2746-4846-b5fe-63c71203b97f\Exec>call RunPowershell.cmd InstallNode.ps1 10.15.3 C:\dotnetbuild\work\7b4a08d9-6316-4b2d-9440-e6abbe37e5cb\Payload\node\bin   || exit /b 1 
"PS: Running 'C:\dotnetbuild\work\7b4a08d9-6316-4b2d-9440-e6abbe37e5cb\Work\09d95c30-2746-4846-b5fe-63c71203b97f\Exec\InstallNode.ps1'  10.15.3 C:\dotnetbuild\work\7b4a08d9-6316-4b2d-9440-e6abbe37e5cb\Payload\node\bin"
Starting download of NodeJs 10.15.3 from http://nodejs.org/dist/v10.15.3/node-v10.15.3-win-x64.zip
Done downloading NodeJS 10.15.3


    Directory: C:\Users\runner\AppData\Local\Temp


Mode                LastWriteTime     Length Name                              
----                -------------     ------ ----                              
d----        10/28/2019     20:58            nodejs                            
Extracting to C:\Users\runner\AppData\Local\Temp\nodejs
Exception calling "ExtractToDirectory" with "2" argument(s): "The file 'C:\Users\runner\AppData\Local\Temp\nodejs\node-v10.15.3-win-x64\CHANGELOG.md' already exists."

@HaoK have you seen this error before? Is node being installed twice?

@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2019

Weird, that looks like an issue with cleanup on the build machines - I don't think we should consider that a blocking issue, especially since we've seen every test pass in Helix on either the current or previous test run

@HaoK
Copy link
Member

HaoK commented Oct 28, 2019

I haven't seen that error before, I can see if there's some hardening we can add to the install node script

@JunTaoLuo JunTaoLuo merged commit 2c6456d into release/3.0 Oct 29, 2019
@JunTaoLuo JunTaoLuo deleted the darc-release/3.0-415c11a4-665d-418c-b7cd-51c83279a567 branch October 29, 2019 01:06
@JunTaoLuo
Copy link
Contributor

The PR is merged and should unblock 3.0.1 @mmitche . Will file followup issues for things that were not addressed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants