Skip to content

Use UnixEpoch for cookie deletion #18126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

martincostello
Copy link
Member

Use the DateTimeOffset.UnixEpoch field instead of a new DateTime value when deleting cookies.

I also tried to update Rfc6238AuthenticationService as well, but that project still targets netstandard2.0 which doesn't have the field available.

Use the DateTimeOffset.UnixEpoch field instead of a new DateTime value when deleting cookies.
@Tratcher Tratcher self-assigned this Jan 4, 2020
@Tratcher Tratcher added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 4, 2020
@Tratcher Tratcher merged commit b6b5319 into dotnet:master Jan 4, 2020
@Tratcher
Copy link
Member

Tratcher commented Jan 4, 2020

Thanks

@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Jan 4, 2020
@martincostello martincostello deleted the Use-Epoch branch January 4, 2020 20:40
martincostello added a commit to martincostello/aspnetcore that referenced this pull request Jan 5, 2020
Apply more changes omitted from dotnet#18126 and dotnet#18128, and use RandomNumberGenerator.Fill() and DateTimeOffset.UnixEpoch for supported TFMs.
HaoK pushed a commit that referenced this pull request Jan 6, 2020
Apply more changes omitted from #18126 and #18128, and use RandomNumberGenerator.Fill() and DateTimeOffset.UnixEpoch for supported TFMs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants