Use RandomNumberGenerator.Fill() #18128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new RandomNumberGenerator.Fill() method instead of maintaining instances of RandomNumberGenerator to use GetBytes().
martincostello
requested review from
analogrelay,
SteveSandersonMS and
Tratcher
as code owners
|
Looks like this one's a bit overly aggressive... |
Revert usage of RandomNumberGenerator.Fill() as the project still targets netstandard2.0.
|
Two instances of |
GrabYourPitchforks
approved these changes
Jan 4, 2020
|
Thanks |
martincostello
added a commit
to martincostello/aspnetcore
that referenced
this pull request
Jan 5, 2020
Apply more changes omitted from dotnet#18126 and dotnet#18128, and use RandomNumberGenerator.Fill() and DateTimeOffset.UnixEpoch for supported TFMs.
HaoK
pushed a commit
that referenced
this pull request
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
RandomNumberGenerator.Fill()method instead of maintaining various instances ofRandomNumberGeneratorto useGetBytes().Also happens to fix the
RandomNumberGeneratorinstance(s) created byWebSocketClientfor the test host not being disposed of.