Marked the Mono.WebAssembly.Interop package as non-shipping #21367
Conversation
This has shipped few times and we've manually unlisted it, but those were supposed to not go out. This package has been replaced by Microsoft.JSInterop.WebAssembly package
| <IsPackable>true</IsPackable> | ||
| <IsShipping>true</IsShipping> | ||
| <IsPackable>false</IsPackable> | ||
| <IsShipping>false</IsShipping> |
There was a problem hiding this comment.
- Changing
$(IsPackable)will break the Microsoft.AspNetCore.Blazor.Templates.csproj template. Suggest that template should either be deleted or removed from the project templates meta-package (if it hasn't already). - What are we keeping this project for? I don't see references to it other than in Microsoft.AspNetCore.Blazor.Templates.csproj and general infrastructure files e.g. eng/ProjectReferences.props. Suggest cleaning up that file and ComponentsNoDeps.slnf.
- When
$(IsPackable)isfalse, changing$(IsShipping)mainly controls versions. Does the version matter?
| <IsShipping>false</IsShipping> | |
| <IsPackable>true</IsPackable> | |
| <IsShipping>false</IsShipping> |
There was a problem hiding this comment.
@dougbu, the only thing which matters at this point is to make this not ship any more. Are you saying when IsPackable is false the package will be shipped anyway?
I don't want to do more than this for now as things will be resolved after blazor-wasm will merge into master (eventually)
There was a problem hiding this comment.
Are you saying when
IsPackableisfalsethe package will be shipped anyway?
No. But, the project has a version which will show up in the Blazor template and break anyone trying to use it. In addition, the version will remain the same when shipping versions stabilize.
There was a problem hiding this comment.
Ok. That template is also currently marked to not ship. So I think simply marking this as non-shipping and leaving the IsPackable as is resolves your concern.
Pilchie
added
the
area-infrastructure
…embly.Interop.csproj Co-authored-by: Doug Bunting <[email protected]>
src/Components/Blazor/Mono.WebAssembly.Interop/src/Mono.WebAssembly.Interop.csproj
Outdated
Show resolved
Hide resolved
…embly.Interop.csproj
No description provided.