Skip to content

Marked the Mono.WebAssembly.Interop package as non-shipping #21367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Marked the Mono.WebAssembly.Interop package as non-shipping #21367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd38355
Marked the Mono.WebAssembly.Interop package as non-shipping
mkArtakMSFT Apr 30, 2020
103ab83
Update src/Components/Blazor/Mono.WebAssembly.Interop/src/Mono.WebAss…
mkArtakMSFT Apr 30, 2020
22843f9
Update src/Components/Blazor/Mono.WebAssembly.Interop/src/Mono.WebAss…
mkArtakMSFT Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Blazor/Mono.WebAssembly.Interop/src/Mono.WebAssembly.Interop.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageTags>wasm;javascript;interop</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<IsPackable>true</IsPackable>
<IsShipping>true</IsShipping>
<IsShipping>false</IsShipping>
Copy link
Contributor

@dougbu dougbu Apr 30, 2020 •
edited by mkArtakMSFT
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Changing $(IsPackable) will break the Microsoft.AspNetCore.Blazor.Templates.csproj template. Suggest that template should either be deleted or removed from the project templates meta-package (if it hasn't already).
  2. What are we keeping this project for? I don't see references to it other than in Microsoft.AspNetCore.Blazor.Templates.csproj and general infrastructure files e.g. eng/ProjectReferences.props. Suggest cleaning up that file and ComponentsNoDeps.slnf.
  3. When $(IsPackable) is false, changing $(IsShipping) mainly controls versions. Does the version matter?
Suggested change
<IsShipping>false</IsShipping>
<IsPackable>true</IsPackable>
<IsShipping>false</IsShipping>

Copy link
Contributor Author

@mkArtakMSFT mkArtakMSFT Apr 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu, the only thing which matters at this point is to make this not ship any more. Are you saying when IsPackable is false the package will be shipped anyway?

I don't want to do more than this for now as things will be resolved after blazor-wasm will merge into master (eventually)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying when IsPackable is false the package will be shipped anyway?

No. But, the project has a version which will show up in the Blazor template and break anyone trying to use it. In addition, the version will remain the same when shipping versions stabilize.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. That template is also currently marked to not ship. So I think simply marking this as non-shipping and leaving the IsPackable as is resolves your concern.

<HasReferenceAssembly>false</HasReferenceAssembly>
</PropertyGroup>

Expand Down