Skip to content

Fix HTTP/2 tests that use HttpClient and H2C #24981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Fix HTTP/2 tests that use HttpClient and H2C #24981

merged 3 commits into from
Aug 18, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 17, 2020

Fixes #24902

@JamesNK JamesNK added area-grpc Includes: GRPC wire-up, templates area-servers labels Aug 17, 2020

protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
request.VersionPolicy = HttpVersionPolicy.RequestVersionOrHigher;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You plan on using Exact in gRPC, no?

Suggested change
request.VersionPolicy = HttpVersionPolicy.RequestVersionOrHigher;
request.VersionPolicy = HttpVersionPolicy.RequestVersionExact;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically gRPC should work with HTTP/3 so OrHigher seems like the best choice.

@JamesNK JamesNK added this to the 5.0.0-rc1 milestone Aug 18, 2020
@JamesNK JamesNK added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 18, 2020
@JamesNK JamesNK changed the base branch from master to release/5.0 August 18, 2020 07:27
@JamesNK JamesNK merged commit f68f5b0 into release/5.0 Aug 18, 2020
@JamesNK JamesNK deleted the jamesnk/h2c branch August 18, 2020 09:12
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable failing H2C tests
4 participants