-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix HTTP/2 tests that use HttpClient and H2C #24981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -100,6 +100,7 @@ private InteropClient(ClientOptions options) | |||||
{ | ||||||
#pragma warning disable CS0618 // Type or member is obsolete | ||||||
loggerOptions.IncludeScopes = true; | ||||||
loggerOptions.DisableColors = true; | ||||||
#pragma warning restore CS0618 // Type or member is obsolete | ||||||
}); | ||||||
}); | ||||||
|
@@ -167,7 +168,7 @@ private async Task<IChannelWrapper> HttpClientCreateChannel() | |||||
httpClientHandler.ClientCertificates.Add(cert); | ||||||
} | ||||||
|
||||||
var httpClient = new HttpClient(httpClientHandler); | ||||||
var httpClient = new HttpClient(new VersionPolicyHandler(httpClientHandler)); | ||||||
|
||||||
var channel = GrpcChannel.ForAddress($"{scheme}://{options.ServerHost}:{options.ServerPort}", new GrpcChannelOptions | ||||||
{ | ||||||
|
@@ -179,7 +180,20 @@ private async Task<IChannelWrapper> HttpClientCreateChannel() | |||||
return new GrpcChannelWrapper(channel); | ||||||
} | ||||||
|
||||||
private bool IsHttpClient() => string.Equals(options.ClientType, "httpclient", StringComparison.OrdinalIgnoreCase); | ||||||
// TODO(JamesNK): This type can be removed in the future when Grpc.Net.Client sets VersionPolicy automatically. | ||||||
// https://github.com/grpc/grpc-dotnet/pull/987 | ||||||
private class VersionPolicyHandler : DelegatingHandler | ||||||
JamesNK marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
{ | ||||||
public VersionPolicyHandler(HttpMessageHandler innerHandler) : base(innerHandler) | ||||||
{ | ||||||
} | ||||||
|
||||||
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) | ||||||
{ | ||||||
request.VersionPolicy = HttpVersionPolicy.RequestVersionOrHigher; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You plan on using Exact in gRPC, no?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Theoretically gRPC should work with HTTP/3 so OrHigher seems like the best choice. |
||||||
return base.SendAsync(request, cancellationToken); | ||||||
} | ||||||
} | ||||||
|
||||||
private async Task<ChannelCredentials> CreateCredentialsAsync(bool? useTestCaOverride = null) | ||||||
{ | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.