Quarantine some tests #26332
Merged
Quarantine some tests #26332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
halter73,
jkotalik,
SteveSandersonMS,
Tratcher and
a team
as code owners
pranavkm
approved these changes
Sep 25, 2020
|
Hello @BrennanConroy! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 46 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Tratcher
approved these changes
Sep 25, 2020
This was referenced Sep 25, 2020
BrennanConroy
commented
Sep 25, 2020
| @@ -422,13 +422,6 @@ public async Task ConfigurationTouchedStress_InProcess() | |||
| await ConfigurationTouchedStress(HostingModel.InProcess); | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| [RequiresNewShim] | |||
| public async Task ConfigurationTouchedStress_OutOfProcess() | |||
There was a problem hiding this comment.
Yeah for out of proc this test wasn't really useful and just prone to flakiness. There are scenarios with out of proc that can still cause the app to return 502s during shutdown with out of proc. With inproc, it should be a guarantee.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26331 and #26330