Skip to content

Quarantine some tests #26332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 25, 2020
Merged

Quarantine some tests #26332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e91624a
Quarantine some tests
BrennanConroy Sep 25, 2020
80c41fe
remove test
BrennanConroy Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/test/E2ETest/Tests/InputFileTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public void CanUploadSingleSmallFile()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26331")]
public void CanUploadSingleLargeFile()
{
// Create a large text file
Expand Down
7 changes: 0 additions & 7 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/ShutdownTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,13 +422,6 @@ public async Task ConfigurationTouchedStress_InProcess()
await ConfigurationTouchedStress(HostingModel.InProcess);
}

[ConditionalFact]
[RequiresNewShim]
public async Task ConfigurationTouchedStress_OutOfProcess()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jkotalik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for out of proc this test wasn't really useful and just prone to flakiness. There are scenarios with out of proc that can still cause the app to return 502s during shutdown with out of proc. With inproc, it should be a guarantee.

{
await ConfigurationTouchedStress(HostingModel.OutOfProcess);
}

private async Task ConfigurationTouchedStress(HostingModel hostingModel)
{
var deploymentResult = await DeployAsync(Fixture.GetBaseDeploymentParameters(hostingModel));
Expand Down
1 change: 1 addition & 0 deletions src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ public async Task WriterThrowsCanceledException()

[ConditionalFact]
[Repeat]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26330")]
public async Task ReaderThrowsCanceledException()
{
var readIsAsyncCompletionSource = CreateTaskCompletionSource();
Expand Down