Make sure SharedFx & TargetingPack msi names match

[wtgodbe]

Resolves #28029. The name of the standalone .msi's here weren't matching what gets into VS, meaning that you can't repair a VS installation with the standalone bundle. The solution is to make sure the names match in both places (the .msi should be versioned)

[joeloff]

Check the wixlib authoring. I seem to remember it referencing the MSI name using the project reference, but I'm almost certain it's using the project.outputname, so we should be good then.

[joeloff]

Looks good, but we just need to confirm the wixlib reference

[wtgodbe]

@JunTaoLuo @joeloff please re-review - the previous issue was that OutputName needs to be set in the .wixproj's before they import d.b.t, but packageVersion isn't available until after we import d.b.t. So, I set a prefix and suffix to outputname in the projects, then construct it from those + the packageVersion in wix.common.targets, where packageversion is available.

[joeloff]

And PackageName should remain consistent when it's doing the copy/rename later on? Or is that a potential issue to deal with in the future if something gets renamed?

[wtgodbe]

And PackageName should remain consistent when it's doing the copy/rename later on? Or is that a potential issue to deal with in the future if something gets renamed?

Do you mean PackageFileName? I'm not exactly sure what the copy/rename behavior is - but, this maintains the old scheme (OutputName is set before we import the props/targets from WiX, PackageFileName is set after we're done processing Directory.Build.Targets and the WiX targets), I just had to move the setting of OutputName to after PackageVersion is available. I believe the timing should be the same as before, just with different names.

[joeloff]

Ok, as long as the target runs for each project separately, then

aspnetcore/src/Installers/Windows/Wix.targets

Line 82 in da3e434

<Target Name="CopyToArtifactsDirectory"

should be using the same value and then we're good

[wtgodbe]

The .msi is now named aspnetcore-runtime-5.0.1-ci-win-x64.msi (plus the same for x86, arm64)