Skip to content

Fix .msi names #28572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix .msi names #28572

merged 1 commit into from
Dec 10, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Dec 10, 2020

  • Set OutputName before using it it set Cabinet
  • Append TargetExt to PackageFileName after it's been set rather than before

Should unblock dotnet/installer#9199. Currently we aren't publishing any sharedFx/TargetingPack .msi's, because the file doesn't have an extension.

@wtgodbe wtgodbe requested review from joeloff and a team December 10, 2020 17:45
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Dec 10, 2020
@wtgodbe wtgodbe added this to the 5.0.2 milestone Dec 10, 2020
@wtgodbe wtgodbe mentioned this pull request Dec 10, 2020
Closed
@Pilchie Pilchie added the feature-installers Includes: Installers label Dec 10, 2020
@wtgodbe wtgodbe merged commit a8646e3 into release/5.0 Dec 10, 2020
@wtgodbe wtgodbe deleted the wtgodbe/FixInstallerName branch December 10, 2020 20:01
wtgodbe added a commit that referenced this pull request Feb 24, 2021
@wtgodbe
Fix .msi names (#28572)
30e5d11
@wtgodbe wtgodbe mentioned this pull request Feb 24, 2021
Merged
wtgodbe added a commit that referenced this pull request Mar 9, 2021
@wtgodbe
[release/3.1] Make sure SharedFx & TargetingPack msi names match (#30439
b8a46a8 
)

* Make sure SharedFx & TargetingPack msi names match (#28298)

* Make sure SharedFx & TargetingPack msi names match

* Insert packageVersion into OutputName when available

* Move props around again

* Fix .msi names (#28572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
feature-installers Includes: Installers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @joeloff @Pilchie