-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Blazor WebAssembly & WebView JS to .NET Streaming Interop Support #33986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Components/Web.JS/src/Platform/WebView/WebViewStreamingInterop.ts
Outdated
Show resolved
Hide resolved
src/Components/Web/src/Forms/InputFile/SharedBrowserFileStream.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/JSInterop/src/WebAssemblyJSRuntime.cs
Outdated
Show resolved
Hide resolved
src/Components/Web/src/Forms/InputFile/RemoteBrowserFileStreamOptions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @TanayParikh! This looks great to me.
fyi/ Had to change the WebView base64 serialization slightly due to stack overflow concerns on large byte arrays. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
CI passed but status isn't being reported for some reason. Could someone with admin rights please merge? @dotnet/aspnet-build https://dev.azure.com/dnceng/public/_build/results?buildId=1239168&view=results |
@TanayParikh all closing and reopening did was cancel the auto-merge and start another build that likely won't report back to GitHub either 😀 |
Thanks for merging. Wasn't sure why the CI status wasn't being reported to GitHub and figured closing/re-opening may re-trigger the reporting (of the new CI run). |
RemoteJSDataStream
into a sharedBaseJSDataStream
which is shared across the 3 platforms. Did this instead of putting it intoJSInterop
to avoid creating additional public APIs per Javier's recommendation.ReceiveJSDataChunk
needs to be refined (potential synchronization issue)BaseJSDataStream
(will do this after everything else is approved)Fixes: #33638
Fixes: #27862
Part of: #30289