Skip to content

Blazor WebAssembly & WebView JS to .NET Streaming Interop Support #33986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Jul 15, 2021

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Jul 1, 2021

  • Adds support for Blazor WebAssembly & WebView JS to .NET Streaming Interop
  • Refactored the logic from RemoteJSDataStream into a shared BaseJSDataStream which is shared across the 3 platforms. Did this instead of putting it into JSInterop to avoid creating additional public APIs per Javier's recommendation.
  • TODO:

Fixes: #33638
Fixes: #27862
Part of: #30289

@TanayParikh TanayParikh added the area-blazor Includes: Blazor, Razor Components label Jul 1, 2021
@TanayParikh TanayParikh marked this pull request as ready for review July 1, 2021 23:42
@TanayParikh TanayParikh requested a review from a team as a code owner July 1, 2021 23:42
@pranavkm pranavkm requested a review from MackinnonBuck July 1, 2021 23:56
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @TanayParikh! This looks great to me.

TanayParikh and others added 2 commits July 14, 2021 10:49
* Address `JS` to `DotNet` byte[] Interop API Review Feedback

Fixes: #34327

* Update RemoteJSDataStreamTest.cs

* Update JSRuntimeTest.cs
@TanayParikh TanayParikh added the blocked The work on this issue is blocked due to some dependency label Jul 15, 2021
@TanayParikh
Copy link
Contributor Author

fyi/ Had to change the WebView base64 serialization slightly due to stack overflow concerns on large byte arrays.

@TanayParikh TanayParikh removed the blocked The work on this issue is blocked due to some dependency label Jul 15, 2021
@TanayParikh TanayParikh enabled auto-merge (squash) July 15, 2021 02:12
@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TanayParikh
Copy link
Contributor Author

CI passed but status isn't being reported for some reason. Could someone with admin rights please merge? @dotnet/aspnet-build

https://dev.azure.com/dnceng/public/_build/results?buildId=1239168&view=results

auto-merge was automatically disabled July 15, 2021 04:26

Pull request was closed

@TanayParikh TanayParikh reopened this Jul 15, 2021
@TanayParikh TanayParikh enabled auto-merge (squash) July 15, 2021 04:27
@dougbu dougbu merged commit eccb20d into main Jul 15, 2021
@dougbu dougbu deleted the taparik/wasmWebViewJSToDotnetStreaming branch July 15, 2021 04:27
@ghost ghost added this to the 6.0-preview7 milestone Jul 15, 2021
@dougbu
Copy link
Member

dougbu commented Jul 15, 2021

@TanayParikh all closing and reopening did was cancel the auto-merge and start another build that likely won't report back to GitHub either 😀

@TanayParikh
Copy link
Contributor Author

@TanayParikh all closing and reopening did was cancel the auto-merge and start another build that likely won't report back to GitHub either 😀

Thanks for merging. Wasn't sure why the CI status wasn't being reported to GitHub and figured closing/re-opening may re-trigger the reporting (of the new CI run).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor Support Large File Uploads Blazor Server & WebAssembly cannot read large file streams from client
4 participants