Exit after container creation script #34945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
reviewed
Aug 2, 2021
| @@ -9,3 +9,6 @@ git submodule update --init --recursive | |||
| # Also run the full restore on the repo so that go-to definition | |||
| # and other language features will be available in C# files | |||
| ./restore.sh | |||
| # The container creation script is executed in a new Bash instance | |||
| # so we exit at the end to avoid the creation process lingering. | |||
| exit | |||
There was a problem hiding this comment.
Maybe my bash is rusty, but don't scripts implicitly exit their host process when they reach the end?
There was a problem hiding this comment.
Yep -- it does. This is more so working around some funkiness with the way Codespaces seems to launch the postCommand script.
Pilchie
added
the
area-infrastructure
wtgodbe
approved these changes
Aug 6, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves feedback given in #34436 (comment).